Re: Review Request 52149: Added support for waiting on child containers to the default executor.

2016-09-26 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52149/ --- (Updated Sept. 26, 2016, 10:42 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 52149: Added support for waiting on child containers to the default executor.

2016-09-26 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52149/#review150433 --- Fix it, then Ship it! src/launcher/default_executor.cpp (line

Re: Review Request 52149: Added support for waiting on child containers to the default executor.

2016-09-25 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52149/ --- (Updated Sept. 26, 2016, 4:31 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 52149: Added support for waiting on child containers to the default executor.

2016-09-25 Thread Anand Mazumdar
> On Sept. 24, 2016, 9:57 p.m., Vinod Kone wrote: > > src/launcher/default_executor.cpp, lines 797-803 > > > > > > Would be great if these can be merged into one struct `Container` > > > > struct Container

Re: Review Request 52149: Added support for waiting on child containers to the default executor.

2016-09-25 Thread Anand Mazumdar
> On Sept. 24, 2016, 9:53 p.m., Vinod Kone wrote: > > src/launcher/default_executor.cpp, line 427 > > > > > > just inline this function. This is invoked by the `retry()` handler too asynchronously. Hence, it can't

Re: Review Request 52149: Added support for waiting on child containers to the default executor.

2016-09-25 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52149/ --- (Updated Sept. 25, 2016, 10:05 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 52149: Added support for waiting on child containers to the default executor.

2016-09-24 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52149/#review150318 --- src/launcher/default_executor.cpp (lines 796 - 802)

Re: Review Request 52149: Added support for waiting on child containers to the default executor.

2016-09-24 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52149/#review150316 --- src/launcher/default_executor.cpp (line 132)

Re: Review Request 52149: Added support for waiting on child containers to the default executor.

2016-09-22 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52149/ --- (Updated Sept. 23, 2016, 3:28 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 52149: Added support for waiting on child containers to the default executor.

2016-09-22 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52149/ --- (Updated Sept. 22, 2016, 7:33 p.m.) Review request for mesos and Vinod Kone.