Re: Review Request 52516: Add test for `AGENT_ADDED` and `AGENT_REMOVED` events.

2016-10-06 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52516/#review151679 --- Fix it, then Ship it! src/tests/api_tests.cpp (lines 1416 -

Re: Review Request 52516: Add test for `AGENT_ADDED` and `AGENT_REMOVED` events.

2016-10-06 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52516/#review151653 --- src/tests/api_tests.cpp (line 1486)

Re: Review Request 52516: Add test for `AGENT_ADDED` and `AGENT_REMOVED` events.

2016-10-05 Thread Zhitao Li
> On Oct. 5, 2016, 6:14 p.m., Anand Mazumdar wrote: > > src/tests/api_tests.cpp, lines 1458-1459 > > > > > > Do you need this? Why can't we just wait on the `event` from the > > decoder. I'm using this to capture

Re: Review Request 52516: Add test for `AGENT_ADDED` and `AGENT_REMOVED` events.

2016-10-05 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52516/ --- (Updated Oct. 5, 2016, 11:48 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 52516: Add test for `AGENT_ADDED` and `AGENT_REMOVED` events.

2016-10-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52516/#review151534 --- Patch looks great! Reviews applied: [51774, 52515, 52516]

Re: Review Request 52516: Add test for `AGENT_ADDED` and `AGENT_REMOVED` events.

2016-10-05 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52516/#review151528 --- Nice Test! src/tests/api_tests.cpp (line 1407)

Re: Review Request 52516: Add test for `AGENT_ADDED` and `AGENT_REMOVED` events.

2016-10-05 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52516/ --- (Updated Oct. 5, 2016, 3:30 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 52516: Add test for `AGENT_ADDED` and `AGENT_REMOVED` events.

2016-10-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52516/#review151381 --- Patch looks great! Reviews applied: [51774, 52515, 52516]

Re: Review Request 52516: Add test for `AGENT_ADDED` and `AGENT_REMOVED` events.

2016-10-04 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52516/ --- (Updated Oct. 4, 2016, 2:44 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 52516: Add test for `AGENT_ADDED` and `AGENT_REMOVED` events.

2016-10-04 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52516/ --- (Updated Oct. 4, 2016, 2:43 p.m.) Review request for mesos, Anand Mazumdar,