Re: Review Request 54212: Fixed overlay backend provisioning multi images symlink.

2017-01-25 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54212/#review162959 --- Fix it, then Ship it! src/slave/containerizer/mesos/provisione

Re: Review Request 54212: Fixed overlay backend provisioning multi images symlink.

2017-01-24 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54212/ --- (Updated Jan. 24, 2017, 12:34 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 54212: Fixed overlay backend provisioning multi images symlink.

2017-01-22 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54212/#review162576 --- src/slave/containerizer/mesos/provisioner/backends/overlay.cpp (l

Re: Review Request 54212: Fixed overlay backend provisioning multi images symlink.

2017-01-19 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54212/ --- (Updated Jan. 19, 2017, 4:08 a.m.) Review request for mesos, Avinash sridharan,

Re: Review Request 54212: Fixed overlay backend provisioning multi images symlink.

2017-01-03 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54212/ --- (Updated Jan. 3, 2017, 2:46 p.m.) Review request for mesos, Avinash sridharan,

Re: Review Request 54212: Fixed overlay backend provisioning multi images symlink.

2016-12-19 Thread Gilbert Song
> On Dec. 15, 2016, 11:22 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/provisioner/backends/overlay.cpp, line 167 > > > > > > Do you need to create the directory first? backendDir/scratch/links > > might no

Re: Review Request 54212: Fixed overlay backend provisioning multi images symlink.

2016-12-16 Thread Jie Yu
> On Dec. 15, 2016, 7:22 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/provisioner/backends/overlay.cpp, line 167 > > > > > > Do you need to create the directory first? backendDir/scratch/links > > might not

Re: Review Request 54212: Fixed overlay backend provisioning multi images symlink.

2016-12-16 Thread Gilbert Song
> On Dec. 15, 2016, 11:22 a.m., Jie Yu wrote: > > src/tests/containerizer/provisioner_backend_tests.cpp, line 96 > > > > > > instead of using os::getcwd(). let's use sandbox.get() consistently in > > this file. Fixe

Re: Review Request 54212: Fixed overlay backend provisioning multi images symlink.

2016-12-16 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54212/ --- (Updated Dec. 16, 2016, 10:03 a.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 54212: Fixed overlay backend provisioning multi images symlink.

2016-12-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54212/#review159352 --- src/slave/containerizer/mesos/provisioner/backends/overlay.cpp (l

Re: Review Request 54212: Fixed overlay backend provisioning multi images symlink.

2016-12-15 Thread Gilbert Song
> On Nov. 30, 2016, 12:21 p.m., Zhitao Li wrote: > > src/slave/containerizer/mesos/provisioner/backends/overlay.cpp, line 167 > > > > > > Do we want to consider maintain a similar hierarchy as `scratch`? It > > seem

Re: Review Request 54212: Fixed overlay backend provisioning multi images symlink.

2016-12-15 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54212/ --- (Updated Dec. 15, 2016, 9:52 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 54212: Fixed overlay backend provisioning multi images symlink.

2016-12-14 Thread Jie Yu
> On Nov. 30, 2016, 8:21 p.m., Zhitao Li wrote: > > src/slave/containerizer/mesos/provisioner/backends/overlay.cpp, line 167 > > > > > > Do we want to consider maintain a similar hierarchy as `scratch`? It > > seems

Re: Review Request 54212: Fixed overlay backend provisioning multi images symlink.

2016-11-30 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54212/#review157458 --- src/slave/containerizer/mesos/provisioner/backends/overlay.cpp (l