Re: Review Request 58048: Added id to Resource.DiskInfo.

2017-09-06 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58048/#review184703 --- include/mesos/mesos.proto Lines 1044 (patched)

Re: Review Request 58048: Added id to Resource.DiskInfo.

2017-09-02 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58048/#review184432 --- This might need to be adjusted based on this:

Re: Review Request 58048: Added id to Resource.DiskInfo.

2017-08-28 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58048/#review183960 --- src/common/resources.cpp Line 187 (original), 187 (patched)

Re: Review Request 58048: Added id to Resource.DiskInfo.

2017-05-19 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58048/ --- (Updated May 19, 2017, 11:16 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 58048: Added id to Resource.DiskInfo.

2017-05-19 Thread Benjamin Bannier
> On May 17, 2017, 5:12 p.m., Qian Zhang wrote: > > src/tests/resources_tests.cpp > > Lines 2190 (patched) > > > > > > Unused variable? Thanks, also fixed the other sites. - Benjamin

Re: Review Request 58048: Added id to Resource.DiskInfo.

2017-05-19 Thread Benjamin Bannier
> On April 17, 2017, 11:49 a.m., Jie Yu wrote: > > src/tests/resources_tests.cpp > > Lines 2255 (patched) > > > > > > instead of relying on 'count', let's use `size()` instead. > > Qian Zhang wrote: > I think

Re: Review Request 58048: Added id to Resource.DiskInfo.

2017-05-17 Thread Qian Zhang
> On April 17, 2017, 5:49 p.m., Jie Yu wrote: > > src/tests/resources_tests.cpp > > Lines 2255 (patched) > > > > > > instead of relying on 'count', let's use `size()` instead. I think here the intention is to

Re: Review Request 58048: Added id to Resource.DiskInfo.

2017-05-17 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58048/#review175252 --- src/tests/resources_tests.cpp Lines 2190 (patched)

Re: Review Request 58048: Added id to Resource.DiskInfo.

2017-04-17 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58048/#review172076 --- Fix it, then Ship it! src/tests/resources_tests.cpp Lines

Re: Review Request 58048: Added id to Resource.DiskInfo.

2017-04-05 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58048/ --- (Updated April 5, 2017, 3:56 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 58048: Added id to Resource.DiskInfo.

2017-04-03 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58048/#review170832 --- Fix it, then Ship it! src/tests/mesos.hpp Line 1356

Re: Review Request 58048: Added id to Resource.DiskInfo.

2017-03-31 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58048/ --- (Updated March 31, 2017, 11:38 a.m.) Review request for mesos, Jie Yu and Jan