Re: Review Request 64033: Terminated executors if kill task received before launch task.

2017-11-24 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64033/ --- (Updated Nov. 24, 2017, 6:21 p.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 64033: Terminated executors if kill task received before launch task.

2017-11-24 Thread Alexander Rukletsov
> On Nov. 22, 2017, 5:44 p.m., Vinod Kone wrote: > > can you write tests please? Writing a test here is not trivial. We don't have infrastructure in place to "hook" to our executors. All built-in executors are implemented in ".cpp" files, which does not allow to create an instance of executor

Re: Review Request 64033: Terminated executors if kill task received before launch task.

2017-11-24 Thread Alexander Rukletsov
> On Nov. 24, 2017, 1:07 p.m., Andrei Budnik wrote: > > src/docker/executor.cpp > > Lines 386 (patched) > > > > > > Consider moving this check to [the > >

Re: Review Request 64033: Terminated executors if kill task received before launch task.

2017-11-24 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64033/#review191835 --- src/docker/executor.cpp Lines 386 (patched)

Re: Review Request 64033: Terminated executors if kill task received before launch task.

2017-11-22 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64033/#review191748 --- can you write tests please? src/docker/executor.cpp Lines 390

Re: Review Request 64033: Terminated executors if kill task received before launch task.

2017-11-22 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64033/ --- (Updated Nov. 22, 2017, 5:05 p.m.) Review request for mesos, Andrei Budnik,