Re: Review Request 67693: Added filtering for `GET_OPERATIONS` calls.

2018-07-09 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67693/#review205883 --- Patch looks great! Reviews applied: [67693] Passed command:

Re: Review Request 67693: Added filtering for `GET_OPERATIONS` calls.

2018-07-09 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67693/#review205864 --- Ship it! Ship It! - Chun-Hung Hsiao On July 6, 2018, 7:37

Re: Review Request 67693: Added filtering for `GET_OPERATIONS` calls.

2018-07-09 Thread Chun-Hung Hsiao
> On July 5, 2018, 9:55 p.m., Chun-Hung Hsiao wrote: > > src/master/http.cpp > > Lines 3821 (patched) > > > > > > Do we want to: > > 1. Simply skip such operations, as suggested in the code here, or > > 2.

Re: Review Request 67693: Added filtering for `GET_OPERATIONS` calls.

2018-07-06 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67693/#review205822 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67693: Added filtering for `GET_OPERATIONS` calls.

2018-07-06 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67693/ --- (Updated July 6, 2018, 9:37 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 67693: Added filtering for `GET_OPERATIONS` calls.

2018-07-06 Thread Benjamin Bannier
> On July 5, 2018, 11:55 p.m., Chun-Hung Hsiao wrote: > > src/master/http.cpp > > Lines 3821 (patched) > > > > > > Do we want to: > > 1. Simply skip such operations, as suggested in the code here, or > > 2.

Re: Review Request 67693: Added filtering for `GET_OPERATIONS` calls.

2018-07-05 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67693/#review205755 --- src/master/http.cpp Lines 3821 (patched)

Re: Review Request 67693: Added filtering for `GET_OPERATIONS` calls.

2018-06-28 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67693/#review205501 --- Ship it! Ship It! - Jan Schlicht On June 21, 2018, 5:53

Re: Review Request 67693: Added filtering for `GET_OPERATIONS` calls.

2018-06-22 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67693/#review205253 --- Patch looks great! Reviews applied: [67693] Passed command:

Re: Review Request 67693: Added filtering for `GET_OPERATIONS` calls.

2018-06-22 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67693/#review205251 --- PASS: Mesos patch 67693 was successfully built and tested.

Re: Review Request 67693: Added filtering for `GET_OPERATIONS` calls.

2018-06-21 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67693/#review205221 --- PASS: Mesos patch 67693 was successfully built and tested.

Re: Review Request 67693: Added filtering for `GET_OPERATIONS` calls.

2018-06-21 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67693/#review205190 --- PASS: Mesos patch 67693 was successfully built and tested.