On May 26, 2015, 7:26 p.m., Vinod Kone wrote:
include/mesos/slave/oversubscription.proto, line 35
https://reviews.apache.org/r/34581/diff/6/?file=970357#file970357line35
s/future/the future/
Agree.
On May 26, 2015, 7:26 p.m., Vinod Kone wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34581/
---
(Updated May 26, 2015, 8:50 p.m.)
Review request for mesos, Jie Yu, Niklas
On May 22, 2015, 8:50 p.m., Marco Massenzio wrote:
include/mesos/slave/oversubscription.proto, line 34
https://reviews.apache.org/r/34581/diff/2/?file=969904#file969904line34
please consider calling this `QosCorrectiveAction`
(we require CamelCase for our types, in any event;
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34581/#review85252
---
include/mesos/slave/oversubscription.proto
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34581/
---
(Updated May 26, 2015, 9:07 p.m.)
Review request for mesos, Jie Yu, Niklas
On May 26, 2015, 7:26 p.m., Vinod Kone wrote:
include/mesos/slave/oversubscription.proto, line 47
https://reviews.apache.org/r/34581/diff/6/?file=970357#file970357line47
why optional?
Bartek Plotka wrote:
IMO, because we can (only optionally) specify the descriptive reason
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34581/
---
(Updated May 26, 2015, 10:24 p.m.)
Review request for mesos, Jie Yu, Joris Van
On May 26, 2015, 7:26 p.m., Vinod Kone wrote:
include/mesos/slave/oversubscription.proto, line 47
https://reviews.apache.org/r/34581/diff/6/?file=970357#file970357line47
why optional?
Bartek Plotka wrote:
IMO, because we can (only optionally) specify the descriptive reason
On May 22, 2015, 8:50 p.m., Marco Massenzio wrote:
include/mesos/slave/oversubscription.proto, line 34
https://reviews.apache.org/r/34581/diff/2/?file=969904#file969904line34
please consider calling this `QosCorrectiveAction`
(we require CamelCase for our types, in any event;
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34581/#review85067
---
Ship it!
LGTM!
Marco - mind taking a look at the comments and see
On May 22, 2015, 8:50 p.m., Marco Massenzio wrote:
include/mesos/slave/oversubscription.proto, line 49
https://reviews.apache.org/r/34581/diff/2/?file=969904#file969904line49
I have some concerns about this design - given the Note above, this
would imply that we would have
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34581/
---
(Updated May 22, 2015, 9:45 p.m.)
Review request for mesos, Jie Yu, Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34581/#review84984
---
Patch looks great!
Reviews applied: [34581]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34581/
---
(Updated May 22, 2015, 7:46 p.m.)
Review request for mesos, Jie Yu, Niklas
On May 22, 2015, 8:50 p.m., Marco Massenzio wrote:
include/mesos/slave/oversubscription.proto, line 30
https://reviews.apache.org/r/34581/diff/2/?file=969904#file969904line30
nit: s/correction/corrective action
also, prefer needs to be taken
Agree.
Also there is gramma
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34581/#review85016
---
Patch looks great!
Reviews applied: [34581]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34581/#review85055
---
Patch looks great!
Reviews applied: [34581]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34581/#review85045
---
Patch looks great!
Reviews applied: [34581]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34581/
---
(Updated May 23, 2015, 3:30 a.m.)
Review request for mesos, Jie Yu, Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34581/
---
(Updated May 23, 2015, 3:27 a.m.)
Review request for mesos, Jie Yu, Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34581/#review84944
---
Looks good! A few nits and let's get it in
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34581/
---
(Updated May 22, 2015, 2:31 a.m.)
Review request for mesos, Jie Yu, Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34581/
---
Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod
23 matches
Mail list logo
