Re: Review Request 34655: Use relative url in /help generated links point

2015-06-02 Thread Adam B
On May 28, 2015, 10:40 a.m., Adam B wrote: 3rdparty/libprocess/src/help.cpp, line 140 https://reviews.apache.org/r/34655/diff/1/?file=971486#file971486line140 Why does this '/help/' need to be removed? Marco Massenzio wrote: because it's wrong - it shouldn't be there.

Re: Review Request 34655: Use relative url in /help generated links point

2015-06-01 Thread Adam Bordelon
The only help documentation I know of is what I found in process/help.hpp https://github.com/apache/mesos/blob/0.22.1/3rdparty/libprocess/include/process/help.hpp#L93 I couldn't find an existing JIRA for updating the missing help pages, but I did find: MESOS-1267

Re: Review Request 34655: Use relative url in /help generated links point

2015-06-01 Thread haosdent huang
On May 28, 2015, 5:40 p.m., Adam B wrote: 3rdparty/libprocess/src/help.cpp, line 140 https://reviews.apache.org/r/34655/diff/1/?file=971486#file971486line140 Why does this '/help/' need to be removed? Marco Massenzio wrote: because it's wrong - it shouldn't be there. Adam

Re: Review Request 34655: Use relative url in /help generated links point

2015-05-29 Thread Adam B
On May 28, 2015, 10:40 a.m., Adam B wrote: Do you clearly understand why this change is needed? I didn't understand after just reading the JIRA, and had to ask the reporter(s). Mesosphere is hosting the Mesos UI(s) underneath the DCOS UI behind a reverse proxy, so that

Re: Review Request 34655: Use relative url in /help generated links point

2015-05-29 Thread Marco Massenzio
On Fri, May 29, 2015 at 1:40 AM, Adam B a...@mesosphere.io wrote: On May 28, 2015, 10:40 a.m., Adam B wrote: Do you clearly understand why this change is needed? I didn't understand after just reading the JIRA, and had to ask the reporter(s). Mesosphere is hosting the Mesos UI(s)

Re: Review Request 34655: Use relative url in /help generated links point

2015-05-28 Thread Marco Massenzio
On May 28, 2015, 5:40 p.m., Adam B wrote: Do you clearly understand why this change is needed? I didn't understand after just reading the JIRA, and had to ask the reporter(s). Mesosphere is hosting the Mesos UI(s) underneath the DCOS UI behind a reverse proxy, so that

Re: Review Request 34655: Use relative url in /help generated links point

2015-05-28 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34655/#review85571 --- Do you clearly understand why this change is needed? I didn't

Re: Review Request 34655: Use relative url in /help generated links point

2015-05-28 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34655/#review85592 --- Ship it! Ship It! - Marco Massenzio On May 28, 2015, 7:54 a.m.,

Re: Review Request 34655: Use relative url in /help generated links point

2015-05-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34655/#review85544 --- Patch looks great! Reviews applied: [34655] All tests passed. -

Review Request 34655: Use relative url in /help generated links point

2015-05-25 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34655/ --- Review request for mesos and Adam B. Bugs: MESOS-2748