Re: Review Request 35234: libprocess: consistent handling of --enable options

2016-07-09 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35234/#review141479 --- Closing this review due to inactivity. Please see our

Re: Review Request 35234: libprocess: consistent handling of --enable options

2015-08-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35234/#review96594 --- Patch looks great! Reviews applied: [33752, 35084, 35234] All

Re: Review Request 35234: libprocess: consistent handling of --enable options

2015-08-19 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35234/ --- (Updated Aug. 19, 2015, 8:09 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 35234: libprocess: consistent handling of --enable options

2015-08-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35234/#review95915 --- Bad patch! Reviews applied: [33752, 35084] Failed command:

Re: Review Request 35234: libprocess: consistent handling of --enable options

2015-06-23 Thread Cody Maloney
On June 9, 2015, 12:26 a.m., Till Toenshoff wrote: 3rdparty/libprocess/configure.ac, line 31 https://reviews.apache.org/r/35234/diff/1/?file=980998#file980998line31 Can we switch to `#` prefixed comments here instead? James Peach wrote: Originally I used #-comments, but

Re: Review Request 35234: libprocess: consistent handling of --enable options

2015-06-09 Thread James Peach
On June 9, 2015, 12:26 a.m., Till Toenshoff wrote: 3rdparty/libprocess/configure.ac, line 31 https://reviews.apache.org/r/35234/diff/1/?file=980998#file980998line31 Can we switch to `#` prefixed comments here instead? Originally I used #-comments, but since autoconf completely

Review Request 35234: libprocess: consistent handling of --enable options

2015-06-08 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35234/ --- Review request for mesos, Benjamin Hindman, Cody Maloney, and Timothy St. Clair.

Re: Review Request 35234: libprocess: consistent handling of --enable options

2015-06-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35234/#review87118 --- Patch looks great! Reviews applied: [33752, 35084, 35234] All

Re: Review Request 35234: libprocess: consistent handling of --enable options

2015-06-08 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35234/#review87101 --- Great updates - quick style review which applies to the