Re: Review Request 35702: [WIP] Added /reserve HTTP endpoint to the master.

2015-06-26 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35702/ --- (Updated June 26, 2015, 10:55 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 35702: [WIP] Added /reserve HTTP endpoint to the master.

2015-06-26 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35702/ --- (Updated June 26, 2015, 10:55 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 35702: [WIP] Added /reserve HTTP endpoint to the master.

2015-06-25 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35702/ --- (Updated June 26, 2015, 4:44 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 35702: [WIP] Added /reserve HTTP endpoint to the master.

2015-06-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35702/#review89471 --- Patch looks great! Reviews applied: [35714, 35702] All tests

Re: Review Request 35702: [WIP] Added /reserve HTTP endpoint to the master.

2015-06-24 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35702/ --- (Updated June 24, 2015, 3:39 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 35702: [WIP] Added /reserve HTTP endpoint to the master.

2015-06-23 Thread Alexander Rukletsov
On June 22, 2015, 10:20 a.m., Alexander Rukletsov wrote: Before making a thorough review, let's discuss one high level question. Here is the problem how I understand it: we reserve for roles, but our code works mostly with frameworks (allocator methods, Offer protobuf). To

Re: Review Request 35702: [WIP] Added /reserve HTTP endpoint to the master.

2015-06-22 Thread Michael Park
On June 22, 2015, 10:20 a.m., Alexander Rukletsov wrote: Before making a thorough review, let's discuss one high level question. Here is the problem how I understand it: we reserve for roles, but our code works mostly with frameworks (allocator methods, Offer protobuf). To

Re: Review Request 35702: [WIP] Added /reserve HTTP endpoint to the master.

2015-06-22 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35702/#review88760 --- Before making a thorough review, let's discuss one high level

Re: Review Request 35702: [WIP] Added /reserve HTTP endpoint to the master.

2015-06-22 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35702/#review88781 --- src/master/http.cpp (lines 519 - 520)

Re: Review Request 35702: [WIP] Added /reserve HTTP endpoint to the master.

2015-06-21 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35702/ --- (Updated June 22, 2015, 2:35 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 35702: [WIP] Added /reserve HTTP endpoint to the master.

2015-06-21 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35702/ --- (Updated June 22, 2015, 5:29 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 35702: [WIP] Added /reserve HTTP endpoint to the master.

2015-06-21 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35702/ --- (Updated June 22, 2015, 5:11 a.m.) Review request for mesos, Adam B, Benjamin