---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36620/#review95637
---
Ship it!
Ship It!
src/linux/cgroups.cpp (line 1686)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36620/
---
(Updated Aug. 13, 2015, 1:52 p.m.)
Review request for mesos, Benjamin Hindman
On July 28, 2015, 7:20 p.m., Timothy Chen wrote:
I notice there are no new tests added for this, can you add a test to
verify the new change works?
Timothy Chen wrote:
Are you able to add this? Otherwise let's add a TODO and get this in.
Created MESOS-3255 to follow up with tests.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36620/#review95259
---
Patch looks great!
Reviews applied: [36612, 36620]
All tests
On July 28, 2015, 7:20 p.m., Timothy Chen wrote:
I notice there are no new tests added for this, can you add a test to
verify the new change works?
Are you able to add this? Otherwise let's add a TODO and get this in.
- Timothy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36620/#review93329
---
I notice there are no new tests added for this, can you add a test
On July 23, 2015, 5:42 p.m., Timothy Chen wrote:
src/linux/cgroups.cpp, line 1696
https://reviews.apache.org/r/36620/diff/10/?file=1019693#file1019693line1696
Seems like we can just a lambda instead of a new fail method, then we
don't even need to store chain variable right?
We
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36620/#review92901
---
Bad patch!
Reviews applied: [36612, 36620]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36620/
---
(Updated July 23, 2015, 12:21 p.m.)
Review request for mesos and Timothy Chen.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36620/#review92747
---
Patch looks great!
Reviews applied: [36612, 36620]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36620/
---
(Updated July 23, 2015, 12:19 p.m.)
Review request for mesos and Timothy Chen.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36620/
---
(Updated July 22, 2015, 10:04 a.m.)
Review request for mesos and Timothy Chen.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36620/#review92585
---
Patch looks great!
Reviews applied: [36612, 36620]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36620/
---
(Updated July 21, 2015, 3:59 p.m.)
Review request for mesos and Timothy Chen.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36620/
---
(Updated July 21, 2015, 4:42 p.m.)
Review request for mesos and Timothy Chen.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36620/
---
(Updated July 22, 2015, 4:37 a.m.)
Review request for mesos and Timothy Chen.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36620/
---
(Updated July 21, 2015, 5:18 p.m.)
Review request for mesos and Timothy Chen.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36620/#review92432
---
Could you please attach a ticket or explain in the description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36620/#review92549
---
Bad patch!
Reviews applied: [36612]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36620/#review92457
---
src/linux/cgroups.cpp (line 1504)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36620/#review92459
---
src/linux/cgroups.cpp (line 1671)
21 matches
Mail list logo
