---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37065/#review94376
---
Ship it!
Thanks for the exploration, just a few comments on
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37065/#review94393
---
Patch looks great!
Reviews applied: [37065]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37065/#review94394
---
src/tests/containerizer/memory_test_helper.cpp (lines 75 - 76)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37065/#review94431
---
Patch looks great!
Reviews applied: [37065]
All tests passed.
-
On Aug. 6, 2015, 4:47 a.m., Alexander Rojas wrote:
src/tests/containerizer/memory_test_helper.cpp, lines 79-87
https://reviews.apache.org/r/37065/diff/3/?file=1033300#file1033300line79
After reading the man pages, `mlock()` exists in Linux too and frankly
it looks safer to use
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37065/
---
(Updated Aug. 6, 2015, 10:34 a.m.)
Review request for mesos, Benjamin Hindman
On Aug. 6, 2015, 1:21 a.m., Michael Park wrote:
src/tests/containerizer/memory_test_helper.cpp, lines 81-83
https://reviews.apache.org/r/37065/diff/3/?file=1033300#file1033300line81
`mlockall` is not what we want ideally right?
Can we mention that it's not ideal but
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37065/
---
(Updated Aug. 5, 2015, 10:54 p.m.)
Review request for mesos, Benjamin Hindman
On Aug. 3, 2015, 11:36 p.m., Michael Park wrote:
src/tests/containerizer/memory_test_helper.cpp, line 81
https://reviews.apache.org/r/37065/diff/1/?file=1028301#file1028301line81
What's the significance in the order in which these are called? I
would've expected something like:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37065/
---
(Updated Aug. 5, 2015, 10:14 p.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37065/#review94001
---
Thanks for this Artem! I applied the patch and it works. Just a
On Aug. 3, 2015, 11:36 p.m., Michael Park wrote:
src/tests/containerizer/memory_test_helper.cpp, line 81
https://reviews.apache.org/r/37065/diff/1/?file=1028301#file1028301line81
What's the significance in the order in which these are called? I
would've expected something like:
On Aug. 4, 2015, 6:36 a.m., Michael Park wrote:
src/tests/containerizer/memory_test_helper.cpp, line 81
https://reviews.apache.org/r/37065/diff/1/?file=1028301#file1028301line81
What's the significance in the order in which these are called? I
would've expected something like:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37065/
---
Review request for mesos, Benjamin Hindman and switched to 'mcypark'.
Bugs:
14 matches
Mail list logo
