Re: Review Request 37417: Convert Perf event validator to use new shared object.

2015-08-18 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37417/ --- (Updated Aug. 18, 2015, 6:42 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 37417: Convert Perf event validator to use new shared object.

2015-08-18 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37417/ --- (Updated Aug. 18, 2015, 6:12 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 37417: Convert Perf event validator to use new shared object.

2015-08-18 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37417/ --- (Updated Aug. 18, 2015, 6:43 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 37417: Convert Perf event validator to use new shared object.

2015-08-18 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37417/#review95777 --- Paul can you split this change? I personally don't have context on

Re: Review Request 37417: Convert Perf event validator to use new shared object.

2015-08-18 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37417/#review95806 --- Did you still want to use 'Perf' here? If not, I can't tell what

Re: Review Request 37417: Convert Perf event validator to use new shared object.

2015-08-18 Thread Paul Brett
On Aug. 18, 2015, 8:38 p.m., Ben Mahler wrote: Paul can you split this change? I personally don't have context on why we would want to change from sampling 'true' to running against the init process so I'd like Jie or Ian to review that change, but I can help you make the

Re: Review Request 37417: Convert Perf event validator to use new shared object.

2015-08-18 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37417/ --- (Updated Aug. 18, 2015, 11:01 p.m.) Review request for mesos and Ben Mahler.

Review Request 37417: Convert Perf event validator to use new shared object.

2015-08-12 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37417/ --- Review request for mesos. Repository: mesos Description --- Convert