---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37821/#review100784
---
Ship it!
fixed inline.
3rdparty/libprocess/src/process.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37821/
---
(Updated Sept. 21, 2015, 3:53 p.m.)
Review request for mesos, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37821/#review99759
---
Patch looks great!
Reviews applied: [37821]
All tests passed.
-
> On Sept. 10, 2015, 8:20 a.m., Michael Park wrote:
> > I've made a few nit comments below but I have some higher-level questions.
> >
> > (1) In this patch, when the destructor of `ProcessManager` is invoked we
> > immediately start to ignore messages. It's not obvious to me that this is
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37821/
---
(Updated Sept. 13, 2015, 11:01 p.m.)
Review request for mesos, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37821/#review98789
---
Patch looks great!
Reviews applied: [37821]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37821/#review98570
---
Bad patch!
Reviews applied: [37821]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37821/#review98693
---
Patch looks great!
Reviews applied: [37821]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37821/
---
(Updated Sept. 11, 2015, 2:26 p.m.)
Review request for mesos, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37821/#review98329
---
I've made a few nit comments below but I have some higher-level
> On Sept. 10, 2015, 8:20 a.m., Michael Park wrote:
> > I've made a few nit comments below but I have some higher-level questions.
> >
> > (1) In this patch, when the destructor of `ProcessManager` is invoked we
> > immediately start to ignore messages. It's not obvious to me that this is
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37821/
---
(Updated Sept. 10, 2015, 9:25 p.m.)
Review request for mesos, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37821/
---
(Updated Sept. 4, 2015, 2:23 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37821/#review97758
---
Patch looks great!
Reviews applied: [37821]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37821/#review97789
---
Ship it!
Looks good. Just a few little nits.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37821/
---
(Updated Sept. 4, 2015, 9 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37821/#review97817
---
Patch looks great!
Reviews applied: [37821]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37821/
---
(Updated Aug. 27, 2015, 10:59 p.m.)
Review request for mesos, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37821/#review96823
---
Patch looks great!
Reviews applied: [37821]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37821/#review96655
---
3rdparty/libprocess/src/process.cpp (line 2210)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37821/#review96653
---
Patch looks great!
Reviews applied: [37821]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37821/#review96654
---
Sorry folks, there seems to be some kind of data race here... after
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37821/#review96802
---
Patch looks great!
Reviews applied: [37821]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37821/
---
Review request for mesos, Benjamin Hindman, Joris Van Remoortere, and switched
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37821/#review96623
---
Patch looks great!
Reviews applied: [37821]
All tests passed.
-
On Aug. 27, 2015, 2:12 a.m., Neil Conway wrote:
3rdparty/libprocess/src/process.cpp, line 2213
https://reviews.apache.org/r/37821/diff/1/?file=1055467#file1055467line2213
This leaks request.
Thanks Neil! Comments addressed.
- Greg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37821/
---
(Updated Aug. 27, 2015, 4:28 a.m.)
Review request for mesos, Benjamin Hindman,
27 matches
Mail list logo
