Re: Review Request 38279: Enabled resources/attributes discovery

2015-09-21 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38279/#review99733 --- src/tests/hook_tests.cpp (line 659)

Re: Review Request 38279: Enabled resources/attributes discovery

2015-09-21 Thread Guangya Liu
> On 九月 21, 2015, 7:57 a.m., Guangya Liu wrote: > > src/tests/hook_tests.cpp, line 659 > > > > > > s/VerifySlaveResourcesHook/VerifySlaveResourcesDiscoverHook/g > > Felix Abecassis wrote: > I will rename it to

Re: Review Request 38279: Enabled resources/attributes discovery

2015-09-21 Thread Felix Abecassis
> On Sept. 21, 2015, 7:57 a.m., Guangya Liu wrote: > > src/tests/hook_tests.cpp, line 659 > > > > > > s/VerifySlaveResourcesHook/VerifySlaveResourcesDiscoverHook/g > > Felix Abecassis wrote: > I will rename it

Re: Review Request 38279: Enabled resources/attributes discovery

2015-09-21 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38279/#review99892 --- src/hook/manager.cpp (line 270)

Re: Review Request 38279: Enabled resources/attributes discovery

2015-09-21 Thread Guangya Liu
> On 九月 21, 2015, 7:57 a.m., Guangya Liu wrote: > > src/tests/hook_tests.cpp, line 659 > > > > > > s/VerifySlaveResourcesHook/VerifySlaveResourcesDiscoverHook/g > > Felix Abecassis wrote: > I will rename it to

Re: Review Request 38279: Enabled resources/attributes discovery

2015-09-21 Thread Felix Abecassis
> On Sept. 21, 2015, 7:57 a.m., Guangya Liu wrote: > > src/tests/hook_tests.cpp, line 659 > > > > > > s/VerifySlaveResourcesHook/VerifySlaveResourcesDiscoverHook/g I will rename it to

Re: Review Request 38279: Enabled resources/attributes discovery

2015-09-21 Thread Felix Abecassis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38279/ --- (Updated Sept. 22, 2015, 1:26 a.m.) Review request for mesos, Connor Doyle and

Re: Review Request 38279: Enabled resources/attributes discovery

2015-09-21 Thread Felix Abecassis
> On Sept. 22, 2015, 1:33 a.m., Kapil Arya wrote: > > src/tests/hook_tests.cpp, line 695 > > > > > > Is it worth checking that resources indeed contains a "foo" before > > validating the value of "foo"? Not sure

Re: Review Request 38279: Enabled resources/attributes discovery

2015-09-21 Thread Connor Doyle
> On Sept. 14, 2015, 5:34 p.m., Connor Doyle wrote: > > src/hook/manager.cpp, line 261 > > > > > > Please add a comment describing how the order of hook execution is > > determined. e.g. order in which they appear

Re: Review Request 38279: Enabled resources/attributes discovery

2015-09-18 Thread Felix Abecassis
> On Sept. 14, 2015, 5:34 p.m., Connor Doyle wrote: > > src/hook/manager.cpp, line 261 > > > > > > Please add a comment describing how the order of hook execution is > > determined. e.g. order in which they appear

Re: Review Request 38279: Enabled resources/attributes discovery

2015-09-18 Thread Felix Abecassis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38279/ --- (Updated Sept. 19, 2015, 12:51 a.m.) Review request for mesos, Connor Doyle

Re: Review Request 38279: Enabled resources/attributes discovery

2015-09-18 Thread Felix Abecassis
> On Sept. 14, 2015, 6:12 p.m., Connor Doyle wrote: > > src/hook/manager.cpp, line 261 > > > > > > Please also add a test that verifies that the hooks are executed in the > > expected order. For example, have two

Re: Review Request 38279: Enabled resources/attributes discovery

2015-09-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38279/#review99647 --- Patch looks great! Reviews applied: [38279] All tests passed. -

Re: Review Request 38279: Enabled resources/attributes discovery

2015-09-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38279/#review99422 --- Bad patch! Reviews applied: [38279] Failed command:

Re: Review Request 38279: Enabled resources/attributes discovery

2015-09-17 Thread Niklas Nielsen
> On Sept. 14, 2015, 1:20 p.m., Niklas Nielsen wrote: > > Per Connors comment, we need a test to exercise the new code Ping - let's get this in soon :) - Niklas --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 38279: Enabled resources/attributes discovery

2015-09-14 Thread Felix Abecassis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38279/ --- (Updated Sept. 14, 2015, 10:39 a.m.) Review request for mesos, Connor Doyle

Re: Review Request 38279: Enabled resources/attributes discovery

2015-09-14 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38279/#review98879 --- Per Connors comment, we need a test to exercise the new code

Re: Review Request 38279: Enabled resources/attributes discovery

2015-09-14 Thread Connor Doyle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38279/#review98884 --- src/examples/test_hook_module.cpp (line 208)

Re: Review Request 38279: Enabled resources/attributes discovery

2015-09-14 Thread Connor Doyle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38279/#review98886 --- src/hook/manager.cpp (line 261)