Re: Review Request 38289: Handle bad request in Docker registry client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38289/#review98872 --- Ship it! Ship It! - Jojy Varghese On Sept. 11, 2015, 7:34 p.m.,

Re: Review Request 38289: Handle bad request in Docker registry client.

> On Sept. 14, 2015, 6:11 p.m., Anand Mazumdar wrote: > > src/slave/containerizer/provisioners/docker/registry_client.cpp, line 277 > > > > > > Why are we parsing the error JSON to extract the error string from JSON

Re: Review Request 38289: Handle bad request in Docker registry client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38289/#review98876 --- LGTM. Just a minor query around why do we want to parse the error

Re: Review Request 38289: Handle bad request in Docker registry client.

> On Sept. 14, 2015, 6:11 p.m., Anand Mazumdar wrote: > > src/slave/containerizer/provisioners/docker/registry_client.cpp, line 266 > > > > > > Not yours , but can we just do OK().status ? never understood the

Re: Review Request 38289: Handle bad request in Docker registry client.

> On Sept. 14, 2015, 6:11 p.m., Anand Mazumdar wrote: > > src/slave/containerizer/provisioners/docker/registry_client.cpp, line 266 > > > > > > Not yours , but can we just do OK().status ? > > Jojy Varghese wrote:

Re: Review Request 38289: Handle bad request in Docker registry client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38289/#review98643 --- src/slave/containerizer/provisioners/docker/registry_client.cpp

Re: Review Request 38289: Handle bad request in Docker registry client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38289/ --- (Updated Sept. 11, 2015, 7:34 p.m.) Review request for mesos and Jojy

Re: Review Request 38289: Handle bad request in Docker registry client.

> On Sept. 11, 2015, 4:57 a.m., Jojy Varghese wrote: > > src/slave/containerizer/provisioners/docker/registry_client.cpp, line 386 > > > > > > This block should be refactored out so that it can be handled in line >

Re: Review Request 38289: Handle bad request in Docker registry client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38289/#review98722 --- Bad patch! Reviews applied: [37871, 37427, 37773, 38289] Failed

Re: Review Request 38289: Handle bad request in Docker registry client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38289/#review98593 --- Bad patch! Reviews applied: [37871, 37427, 37773, 38289] Failed

Re: Review Request 38289: Handle bad request in Docker registry client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38289/#review98608 --- src/slave/containerizer/provisioners/docker/registry_client.cpp

Re: Review Request 38289: Handle bad request in Docker registry client.

> On Sept. 11, 2015, 4:57 a.m., Jojy Varghese wrote: > > src/slave/containerizer/provisioners/docker/registry_client.cpp, line 572 > > > > > > You will have to set O_NONBLOCK on the file descriptor. This is done in

Re: Review Request 38289: Handle bad request in Docker registry client.

> On Sept. 11, 2015, 4:57 a.m., Jojy Varghese wrote: > > src/slave/containerizer/provisioners/docker/registry_client.cpp, line 386 > > > > > > This block should be refactored out so that it can be handled in line >

Re: Review Request 38289: Handle bad request in Docker registry client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38289/#review98553 --- src/slave/containerizer/provisioners/docker/registry_client.cpp

Review Request 38289: Handle bad request in Docker registry client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38289/ --- Review request for mesos and Jojy Varghese. Repository: mesos Description