Re: Review Request 38370: Updated docker executor to set container IP in TaskStatus::NetworkInfo.

2015-09-16 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38370/#review99284 --- src/docker/executor.cpp (lines 162 - 164)

Re: Review Request 38370: Updated docker executor to set container IP in TaskStatus::NetworkInfo.

2015-09-16 Thread Niklas Nielsen
> On Sept. 15, 2015, 6:57 p.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [38363, 38364, 38365] > > > > Failed command: ./support/apply-review.sh -n -r 38365 > > > > Error: > > 2015-09-16 01:57:34 URL:https://reviews.apache.org/r/38365/diff/raw/ > > [16233/16233] ->

Re: Review Request 38370: Updated docker executor to set container IP in TaskStatus::NetworkInfo.

2015-09-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38370/#review99297 --- Bad patch! Reviews applied: [38363, 38364, 38365] Failed command:

Re: Review Request 38370: Updated docker executor to set container IP in TaskStatus::NetworkInfo.

2015-09-16 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38370/ --- (Updated Sept. 16, 2015, 6 p.m.) Review request for mesos, Connor Doyle, Jie

Re: Review Request 38370: Updated docker executor to set container IP in TaskStatus::NetworkInfo.

2015-09-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38370/#review99326 --- Patch looks great! Reviews applied: [38363, 38364, 38365, 38366,

Re: Review Request 38370: Updated docker executor to set container IP in TaskStatus::NetworkInfo.

2015-09-16 Thread Kapil Arya
> On Sept. 16, 2015, 3:44 p.m., Niklas Nielsen wrote: > > src/docker/executor.cpp, lines 162-164 > > > > > > Was "Docker.NetworkSettings.IPAddress" in 0.24.0? If so, don't we want > > to deprecate this over a

Re: Review Request 38370: Updated docker executor to set container IP in TaskStatus::NetworkInfo.

2015-09-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38370/#review99149 --- Bad patch! Reviews applied: [38363, 38364, 38365] Failed command:

Re: Review Request 38370: Updated docker executor to set container IP in TaskStatus::NetworkInfo.

2015-09-15 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38370/ --- (Updated Sept. 15, 2015, 5:11 p.m.) Review request for mesos, Connor Doyle,

Re: Review Request 38370: Updated docker executor to set container IP in TaskStatus::NetworkInfo.

2015-09-14 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38370/#review98917 --- src/docker/executor.cpp (line 162)

Re: Review Request 38370: Updated docker executor to set container IP in TaskStatus::NetworkInfo.

2015-09-14 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38370/#review98923 --- +1 on Tim's comment. I think you can just generalize the text to