Re: Review Request 38756: CMake: Add support for compiling the agent with CMake.

2015-09-27 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38756/#review100782 --- Ship it! Ship It! - Joris Van Remoortere On Sept. 26, 2015, 10:

Re: Review Request 38756: CMake: Add support for compiling the agent with CMake.

2015-09-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38756/#review100766 --- Patch looks great! Reviews applied: [38456, 38457, 38529, 38530, 3

Re: Review Request 38756: CMake: Add support for compiling the agent with CMake.

2015-09-26 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38756/ --- (Updated Sept. 26, 2015, 10:57 p.m.) Review request for mesos, Artem Harutyunya

Re: Review Request 38756: CMake: Add support for compiling the agent with CMake.

2015-09-26 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38756/ --- (Updated Sept. 26, 2015, 10:05 p.m.) Review request for mesos, Artem Harutyunya

Re: Review Request 38756: CMake: Add support for compiling the agent with CMake.

2015-09-25 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38756/#review100744 --- This doesn't compiler for me on Ubuntu 15.04 I will work with you o

Re: Review Request 38756: CMake: Add support for compiling the agent with CMake.

2015-09-25 Thread Artem Harutyunyan
> On Sept. 25, 2015, 2:36 p.m., Artem Harutyunyan wrote: > > src/CMakeLists.txt, line 1 > > > > > > I think this file belongs in src/slave. And from top level src/ dir we > > should just be pulling CMakeLists.txt file

Re: Review Request 38756: CMake: Add support for compiling the agent with CMake.

2015-09-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38756/#review100728 --- Patch looks great! Reviews applied: [38456, 38457, 38529, 38530, 3

Re: Review Request 38756: CMake: Add support for compiling the agent with CMake.

2015-09-25 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38756/#review100719 --- Ship it! Also tested on OSX. i.e. ``` mkdir cbuild cd cbuild cmak

Re: Review Request 38756: CMake: Add support for compiling the agent with CMake.

2015-09-25 Thread Alex Clemmer
> On Sept. 25, 2015, 11:16 p.m., Joseph Wu wrote: > > For me, `mkdir build && cd build && cmake .. && make`. > > > > Gave me an error (OSX): > > > > ``` > > Scanning dependencies of target mesos-0.25.0 > > /Applications/Xcode.app/Contents/Developer/usr/bin/make -f > > src/CMakeFiles/mesos-0.25

Re: Review Request 38756: CMake: Add support for compiling the agent with CMake.

2015-09-25 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38756/ --- (Updated Sept. 25, 2015, 11:19 p.m.) Review request for mesos, Artem Harutyunya

Re: Review Request 38756: CMake: Add support for compiling the agent with CMake.

2015-09-25 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38756/#review100714 --- For me, `mkdir build && cd build && cmake .. && make`. Gave me an

Re: Review Request 38756: CMake: Add support for compiling the agent with CMake.

2015-09-25 Thread Alex Clemmer
> On Sept. 25, 2015, 9:36 p.m., Artem Harutyunyan wrote: > > src/CMakeLists.txt, line 1 > > > > > > I think this file belongs in src/slave. And from top level src/ dir we > > should just be pulling CMakeLists.txt file

Re: Review Request 38756: CMake: Add support for compiling the agent with CMake.

2015-09-25 Thread Alex Clemmer
> On Sept. 25, 2015, 5:39 p.m., Joseph Wu wrote: > > src/CMakeLists.txt, lines 34-38 > > > > > > This seems macro-able. > > > > A macro which would let you do something like: > > ``` > > BUILD_PROTO(M

Re: Review Request 38756: CMake: Add support for compiling the agent with CMake.

2015-09-25 Thread Alex Clemmer
> On Sept. 25, 2015, 7:06 a.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [38456, 38457, 38529, 38530, 38531, 38538, 38539, 38540, > > 38541, 38542, 38549, 38550, 38551, 38552, 38751, 38752] > > > > Failed command: ./support/apply-review.sh -n -r 38752 > > > > Error: > >

Re: Review Request 38756: CMake: Add support for compiling the agent with CMake.

2015-09-25 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38756/ --- (Updated Sept. 25, 2015, 10:14 p.m.) Review request for mesos, Artem Harutyunya

Re: Review Request 38756: CMake: Add support for compiling the agent with CMake.

2015-09-25 Thread Artem Harutyunyan
> On Sept. 25, 2015, 2:36 p.m., Artem Harutyunyan wrote: > > LGTM. - Artem --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38756/#review100641

Re: Review Request 38756: CMake: Add support for compiling the agent with CMake.

2015-09-25 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38756/#review100641 --- src/CMakeLists.txt (line 1)

Re: Review Request 38756: CMake: Add support for compiling the agent with CMake.

2015-09-25 Thread Joseph Wu
> On Sept. 25, 2015, 10:39 a.m., Joseph Wu wrote: > > src/CMakeLists.txt, lines 34-38 > > > > > > This seems macro-able. > > > > A macro which would let you do something like: > > ``` > > BUILD_PROTO(

Re: Review Request 38756: CMake: Add support for compiling the agent with CMake.

2015-09-25 Thread Alex Clemmer
> On Sept. 25, 2015, 5:39 p.m., Joseph Wu wrote: > > src/CMakeLists.txt, lines 34-38 > > > > > > This seems macro-able. > > > > A macro which would let you do something like: > > ``` > > BUILD_PROTO(M

Re: Review Request 38756: CMake: Add support for compiling the agent with CMake.

2015-09-25 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38756/#review100625 --- src/CMakeLists.txt (lines 34 - 38)

Re: Review Request 38756: CMake: Add support for compiling the agent with CMake.

2015-09-25 Thread Joseph Wu
> On Sept. 25, 2015, 12:06 a.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [38456, 38457, 38529, 38530, 38531, 38538, 38539, 38540, > > 38541, 38542, 38549, 38550, 38551, 38552, 38751, 38752] > > > > Failed command: ./support/apply-review.sh -n -r 38752 > > > > Error: > >

Re: Review Request 38756: CMake: Add support for compiling the agent with CMake.

2015-09-25 Thread Alex Clemmer
> On Sept. 25, 2015, 7:06 a.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [38456, 38457, 38529, 38530, 38531, 38538, 38539, 38540, > > 38541, 38542, 38549, 38550, 38551, 38552, 38751, 38752] > > > > Failed command: ./support/apply-review.sh -n -r 38752 > > > > Error: > >

Re: Review Request 38756: CMake: Add support for compiling the agent with CMake.

2015-09-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38756/#review100553 --- Bad patch! Reviews applied: [38456, 38457, 38529, 38530, 38531, 38

Review Request 38756: CMake: Add support for compiling the agent with CMake.

2015-09-24 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38756/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu