Re: Review Request 39037: Allow description empty in help information.

2015-10-13 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39037/#review102533 --- Ship it! Will get this committed shortly. 3rdparty/libprocess/sr

Re: Review Request 39037: Allow description empty in help information.

2015-10-12 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39037/#review102381 --- Ship it! Ship It! - Guangya Liu On 十月 13, 2015, 2:47 a.m., haos

Re: Review Request 39037: Allow description empty in help information.

2015-10-12 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39037/ --- (Updated Oct. 13, 2015, 2:47 a.m.) Review request for mesos and Ben Mahler. C

Re: Review Request 39037: Allow description empty in help information.

2015-10-12 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39037/#review102291 --- 3rdparty/libprocess/src/help.cpp (line 43)

Re: Review Request 39037: Allow description empty in help information.

2015-10-12 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39037/#review102290 --- 3rdparty/libprocess/src/help.cpp (lines 41 - 75)

Re: Review Request 39037: Allow description empty in help information.

2015-10-08 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39037/ --- (Updated Oct. 8, 2015, 6:59 a.m.) Review request for mesos and Ben Mahler. Ch

Re: Review Request 39037: Allow description empty in help information.

2015-10-07 Thread haosdent huang
> On Oct. 8, 2015, 5:12 a.m., Guangya Liu wrote: > > 3rdparty/libprocess/src/help.cpp, line 61 > > > > > > I think that the tldr logic does not needs to be changed, we can keep > > it in line 47 Mmm, let me revert t

Re: Review Request 39037: Allow description empty in help information.

2015-10-07 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39037/#review101864 --- 3rdparty/libprocess/src/help.cpp (line 52)

Re: Review Request 39037: Allow description empty in help information.

2015-10-07 Thread Guangya Liu
- Guangya --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39037/#review101821 --- On 十月 7, 2015, 3:04 a.m., haosdent huang wrote: > > -

Re: Review Request 39037: Allow description empty in help information.

2015-10-07 Thread Guangya Liu
> On 十月 7, 2015, 10:01 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/help.cpp, lines 60-63 > > > > > > In your last diff you didn't have this change and the one below to > > conditionally add newlines, why did

Re: Review Request 39037: Allow description empty in help information.

2015-10-07 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39037/#review101821 --- 3rdparty/libprocess/src/help.cpp (lines 51 - 54)

Re: Review Request 39037: Allow description empty in help information.

2015-10-06 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39037/ --- (Updated Oct. 7, 2015, 3:04 a.m.) Review request for mesos and Ben Mahler. Ch

Re: Review Request 39037: Allow description empty in help information.

2015-10-06 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39037/#review101677 --- 3rdparty/libprocess/include/process/help.hpp (line 51)

Re: Review Request 39037: Allow description empty in help information.

2015-10-05 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39037/#review101603 --- Ship it! Ship It! - Guangya Liu On 十月 6, 2015, 4:15 a.m., haosd

Review Request 39037: Allow description empty in help information.

2015-10-05 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39037/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-3104 https://issues.ap