Re: Review Request 40445: Added linter for license headers in some file types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40445/#review108854 --- Ship it! Ship It! - Michael Park On Dec. 3, 2015, 1:06 p.m., Be

Re: Review Request 40445: Added linter for license headers in some file types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40445/ --- (Updated Dec. 3, 2015, 1:06 p.m.) Review request for mesos, Benjamin Hindman, M

Re: Review Request 40445: Added linter for license headers in some file types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40445/#review108805 --- Patch looks great! Reviews applied: [39590, 39591, 39592, 40445]

Re: Review Request 40445: Added linter for license headers in some file types.

> On Dec. 3, 2015, 3:51 a.m., Michael Park wrote: > > support/mesos-style.py, lines 152-153 > > > > > > Why not `print`? Using `print "foo"`-style now (for local consistency). - Benjamin

Re: Review Request 40445: Added linter for license headers in some file types.

> On Dec. 2, 2015, 11:31 p.m., Michael Park wrote: > > support/mesos-style.py, line 6 > > > > > > Why the introduction of the `print` function? Can't we just use `print` > > and `.format`? > > Benjamin Bannier wrote:

Re: Review Request 40445: Added linter for license headers in some file types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40445/ --- (Updated Dec. 3, 2015, 9:29 a.m.) Review request for mesos, Benjamin Hindman, M

Re: Review Request 40445: Added linter for license headers in some file types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40445/#review108772 --- support/mesos-style.py (lines 126 - 127)

Re: Review Request 40445: Added linter for license headers in some file types.

> On Dec. 2, 2015, 11:31 p.m., Michael Park wrote: > > support/mesos-style.py, line 6 > > > > > > Why the introduction of the `print` function? Can't we just use `print` > > and `.format`? > > Benjamin Bannier wrote:

Re: Review Request 40445: Added linter for license headers in some file types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40445/#review108767 --- Patch looks great! Reviews applied: [39590, 39591, 39592, 40445]

Re: Review Request 40445: Added linter for license headers in some file types.

> On Dec. 2, 2015, 11:31 p.m., Michael Park wrote: > > support/mesos-style.py, line 6 > > > > > > Why the introduction of the `print` function? Can't we just use `print` > > and `.format`? This was some drive-by futu

Re: Review Request 40445: Added linter for license headers in some file types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40445/ --- (Updated Dec. 3, 2015, 12:02 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 40445: Added linter for license headers in some file types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40445/#review108745 --- support/mesos-style.py (line 5)

Re: Review Request 40445: Added linter for license headers in some file types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40445/#review108634 --- Patch looks great! Reviews applied: [39590, 39591, 39592, 40445]

Re: Review Request 40445: Added linter for license headers in some file types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40445/ --- (Updated Dec. 2, 2015, 11:18 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 40445: Added linter for license headers in some file types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40445/#review108523 --- Why do we want to introduce a `mesos-license.py` rather than simply

Re: Review Request 40445: Added linter for license headers in some file types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40445/#review108214 --- Patch looks great! Reviews applied: [39590, 39591, 39592, 40445]

Re: Review Request 40445: Added linter for license headers in some file types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40445/ --- (Updated Nov. 27, 2015, 10:52 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 40445: Added linter for license headers in some file types.

> On Nov. 27, 2015, 8:48 a.m., Marco Massenzio wrote: > > support/mesos-license.py, line 30 > > > > > > is this dead code? please remove > > However, I'd like to see the log-level to be set to INFO by defaul and

Re: Review Request 40445: Added linter for license headers in some file types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40445/#review108054 --- support/mesos-license.py (line 29)

Re: Review Request 40445: Added linter for license headers in some file types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40445/#review108032 --- Patch looks great! Reviews applied: [39590, 39591, 39592, 40445]

Re: Review Request 40445: Added linter for license headers in some file types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40445/#review107957 --- LGMT! - Till Toenshoff On Nov. 25, 2015, 9:59 a.m., Benjamin Ban

Re: Review Request 40445: Added linter for license headers in some file types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40445/ --- (Updated Nov. 25, 2015, 9:59 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 40445: Added linter for license headers in some file types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40445/ --- (Updated Nov. 25, 2015, 9:49 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 40445: Added linter for license headers in some file types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40445/ --- (Updated Nov. 25, 2015, 8:55 a.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 40445: Added linter for license headers in some file types.

> On Nov. 18, 2015, 6:21 p.m., Vinod Kone wrote: > > support/hooks/post-rewrite, line 33 > > > > > > instead of calling this script directly, i would recommend calling it > > from mesos-style.py. this way users and t

Re: Review Request 40445: Added linter for license headers in some file types.

> On Nov. 18, 2015, 6:21 p.m., Vinod Kone wrote: > > support/hooks/post-rewrite, line 33 > > > > > > instead of calling this script directly, i would recommend calling it > > from mesos-style.py. this way users and t

Re: Review Request 40445: Added linter for license headers in some file types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40445/#review107079 --- Patch looks great! Reviews applied: [39590, 39591, 39592, 40445]

Re: Review Request 40445: Added linter for license headers in some file types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40445/#review107061 --- support/hooks/post-rewrite (line 33)

Review Request 40445: Added linter for license headers in some file types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40445/ --- Review request for mesos, Benjamin Hindman and Marco Massenzio. Bugs: MESOS-358