Re: Review Request 40767: Take possible isNone() into account when comparing two Option CPU resource numbers.

2015-12-03 Thread Bernd Mathiske
> On Nov. 30, 2015, 9:10 a.m., Ben Mahler wrote: > > src/common/resources.cpp, lines 963-965 > > > > > > Do you know about Option's getOrElse? You can avoid these ternary > > expressions. > > > > Also the

Re: Review Request 40767: Take possible isNone() into account when comparing two Option CPU resource numbers.

2015-12-03 Thread Bernd Mathiske
> On Nov. 30, 2015, 9:10 a.m., Ben Mahler wrote: > > src/common/resources.cpp, lines 963-965 > > > > > > Do you know about Option's getOrElse? You can avoid these ternary > > expressions. > > > > Also the

Re: Review Request 40767: Take possible isNone() into account when comparing two Option CPU resource numbers.

2015-11-30 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40767/#review108327 --- src/common/resources.cpp (lines 962 - 964)

Re: Review Request 40767: Take possible isNone() into account when comparing two Option CPU resource numbers.

2015-11-27 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40767/#review108240 --- Ship it! Ship It! - Avinash sridharan On Nov. 27, 2015, 1:44

Review Request 40767: Take possible isNone() into account when comparing two Option CPU resource numbers.

2015-11-27 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40767/ --- Review request for mesos, Alexander Rukletsov, Avinash sridharan, Klaus Ma,

Re: Review Request 40767: Take possible isNone() into account when comparing two Option CPU resource numbers.

2015-11-27 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40767/ --- (Updated Nov. 27, 2015, 5:44 a.m.) Review request for mesos, Alexander

Re: Review Request 40767: Take possible isNone() into account when comparing two Option CPU resource numbers.

2015-11-27 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40767/#review108226 --- Patch looks great! Reviews applied: [40767] Passed command:

Re: Review Request 40767: Take possible isNone() into account when comparing two Option CPU resource numbers.

2015-11-27 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40767/#review108227 --- Ship it! Ship It! - Klaus Ma On Nov. 27, 2015, 9:44 p.m.,

Re: Review Request 40767: Take possible isNone() into account when comparing two Option CPU resource numbers.

2015-11-27 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40767/#review108235 --- Ship it! Ship It! - Till Toenshoff On Nov. 27, 2015, 1:44