Re: Review Request 40905: [libprocess]: Made `MethodNotAllowed` response compliant to RFC 2616.

2015-12-11 Thread Alexander Rukletsov
> On Dec. 3, 2015, 5:10 p.m., Anand Mazumdar wrote: > > 3rdparty/libprocess/include/process/http.hpp, line 582 > > > > > > hmmm , why do we need another constructor with no response body ? > > > > We have

Re: Review Request 40905: [libprocess]: Made `MethodNotAllowed` response compliant to RFC 2616.

2015-12-10 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40905/#review109775 --- Ship it! Ship It! - Joris Van Remoortere On Dec. 10, 2015,

Re: Review Request 40905: [libprocess]: Made `MethodNotAllowed` response compliant to RFC 2616.

2015-12-09 Thread Alexander Rukletsov
> On Dec. 3, 2015, 5:10 p.m., Anand Mazumdar wrote: > > 3rdparty/libprocess/include/process/http.hpp, line 582 > > > > > > hmmm , why do we need another constructor with no response body ? > > > > We have

Re: Review Request 40905: [libprocess]: Made `MethodNotAllowed` response compliant to RFC 2616.

2015-12-09 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40905/#review109691 --- Ship it! LGTM - Anand Mazumdar On Dec. 10, 2015, 12:12 a.m.,

Re: Review Request 40905: [libprocess]: Made `MethodNotAllowed` response compliant to RFC 2616.

2015-12-03 Thread Guangya Liu
> On Dec. 3, 2015, 12:24 p.m., Guangya Liu wrote: > > src/master/http.cpp, line 385 > > > > > > What about update to > > > > Expecting a 'POST' request, received a '" + request.method + "' request" > >

Re: Review Request 40905: [libprocess]: Made `MethodNotAllowed` response compliant to RFC 2616.

2015-12-03 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40905/ --- (Updated Dec. 3, 2015, 2:34 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 40905: [libprocess]: Made `MethodNotAllowed` response compliant to RFC 2616.

2015-12-03 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40905/#review108845 --- LGTM, Just one minor suggestion + a query regarding why do we need