Re: Review Request 41593: Added `jsonify` function to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41593/ --- (Updated Jan. 15, 2016, 1:26 p.m.) Review request for mesos and Benjamin

Re: Review Request 41593: Added `jsonify` function to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41593/ --- (Updated Jan. 15, 2016, 4 a.m.) Review request for mesos and Benjamin Hindman.

Re: Review Request 41593: Added `jsonify` function to stout.

> On Jan. 14, 2016, 4:14 a.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp, line 659 > > > > > > Why do you need to pull this variable out? This is consistent from the

Re: Review Request 41593: Added `jsonify` function to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41593/#review114398 --- Ship it! 3rdparty/libprocess/3rdparty/stout/README.md (line 250)

Re: Review Request 41593: Added `jsonify` function to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41593/ --- (Updated Jan. 13, 2016, 12:57 a.m.) Review request for mesos and Benjamin

Re: Review Request 41593: Added `jsonify` function to stout.

> On Jan. 5, 2016, 9:28 a.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp, line 107 > > > > > > Here and in all dtrs below: Given that we don't know whether exceptions

Re: Review Request 41593: Added `jsonify` function to stout.

> On Jan. 7, 2016, 10:25 a.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp, lines 97-99 > > > > > > Why this behaviour? I would expect if `set()` is not called,

Re: Review Request 41593: Added `jsonify` function to stout.

> On Jan. 7, 2016, 10:25 a.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/3rdparty/stout/Makefile.am, line 38 > > > > > > Is formatting off or it's just review board? The formatting is off I think. I can't

Re: Review Request 41593: Added `jsonify` function to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41593/ --- (Updated Jan. 8, 2016, 4:47 a.m.) Review request for mesos and Benjamin

Re: Review Request 41593: Added `jsonify` function to stout.

> On Jan. 7, 2016, 10:25 a.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp, lines 97-99 > > > > > > Why this behaviour? I would expect if `set()` is not called,

Re: Review Request 41593: Added `jsonify` function to stout.

> On Jan. 5, 2016, 10:28 a.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp, line 107 > > > > > > Here and in all dtrs below: Given that we don't know whether exceptions

Re: Review Request 41593: Added `jsonify` function to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41593/#review112845 --- Pretty clever code, it would be nice if some of the techniques

Re: Review Request 41593: Added `jsonify` function to stout.

> On Jan. 5, 2016, 2:56 p.m., Alexander Rojas wrote: > > Pretty clever code, it would be nice if some of the techniques were at > > least explained in a blog post with a link in the code. I'm mostly > > concerend about the use of C++17 functions (`std::rank`). Does that mean we > > are

Re: Review Request 41593: Added `jsonify` function to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41593/ --- (Updated Jan. 5, 2016, 10:38 p.m.) Review request for mesos and Benjamin

Re: Review Request 41593: Added `jsonify` function to stout.

> On Jan. 5, 2016, 9:28 a.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp, line 107 > > > > > > Here and in all dtrs below: Given that we don't know whether exceptions