Re: Review Request 41600: Speed up SlaveTest.CommandExecutorWithOverride.

2016-01-15 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41600/#review114812 --- I'm renaming the commit message since this patch doesn't really spe

Re: Review Request 41600: Speed up SlaveTest.CommandExecutorWithOverride.

2016-01-15 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41600/#review114808 --- Ship it! Ship It! - Timothy Chen On Jan. 15, 2016, 5:09 a.m., J

Re: Review Request 41600: Speed up SlaveTest.CommandExecutorWithOverride.

2016-01-14 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41600/#review114669 --- Ship it! Ship It! - haosdent huang On Jan. 15, 2016, 5:09 a.m.,

Re: Review Request 41600: Speed up SlaveTest.CommandExecutorWithOverride.

2016-01-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41600/#review113427 --- Patch looks great! Reviews applied: [41600] Passed command: expor

Re: Review Request 41600: Speed up SlaveTest.CommandExecutorWithOverride.

2016-01-07 Thread Jian Qiu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41600/ --- (Updated 一月 8, 2016, 2:13 a.m.) Review request for mesos and Alexander Rukletso

Re: Review Request 41600: Speed up SlaveTest.CommandExecutorWithOverride

2016-01-07 Thread Jian Qiu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41600/ --- (Updated 一月 7, 2016, 1:41 p.m.) Review request for mesos and Alexander Rukletso

Re: Review Request 41600: Speed up SlaveTest.CommandExecutorWithOverride

2015-12-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41600/#review112280 --- Patch looks great! Reviews applied: [41600] Passed command: expor

Re: Review Request 41600: Speed up SlaveTest.CommandExecutorWithOverride

2015-12-29 Thread Jian Qiu
> On 十二月 28, 2015, 11:15 a.m., Alexander Rukletsov wrote: > > src/tests/slave_tests.cpp, line 435 > > > > > > Mind explaining why do you think explicitly killing the executor is the > > right solution here? I would

Re: Review Request 41600: Speed up SlaveTest.CommandExecutorWithOverride

2015-12-29 Thread Jian Qiu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41600/ --- (Updated 十二月 30, 2015, 2:02 a.m.) Review request for mesos and Alexander Ruklet

Re: Review Request 41600: Speed up SlaveTest.CommandExecutorWithOverride

2015-12-29 Thread Jian Qiu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41600/ --- (Updated 十二月 30, 2015, 2 a.m.) Review request for mesos and Alexander Rukletsov

Re: Review Request 41600: Speed up SlaveTest.CommandExecutorWithOverride

2015-12-28 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41600/#review111967 --- src/tests/slave_tests.cpp (line 435)

Re: Review Request 41600: Speed up SlaveTest.CommandExecutorWithOverride

2015-12-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41600/#review111743 --- Patch looks great! Reviews applied: [41600] Passed command: expor

Re: Review Request 41600: Speed up SlaveTest.CommandExecutorWithOverride

2015-12-22 Thread Jian Qiu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41600/ --- (Updated 十二月 23, 2015, 6:43 a.m.) Review request for mesos and Alexander Ruklet

Review Request 41600: Speed up SlaveTest.CommandExecutorWithOverride

2015-12-22 Thread Jian Qiu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41600/ --- Review request for mesos and Alexander Rukletsov. Bugs: MESOS-4161 https://