Re: Review Request 41613: Added `DEFAULT_ROLE` constant to persistent volume tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41613/#review150016 --- Ship it! Ship It! - Michael Park On Sept. 21, 2016, 6:04

Re: Review Request 41613: Added `DEFAULT_ROLE` constant to persistent volume tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41613/#review149919 --- Patch looks great! Reviews applied: [41613] Passed command:

Re: Review Request 41613: Added `DEFAULT_ROLE` constant to persistent volume tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41613/ --- (Updated Sept. 21, 2016, 6:04 p.m.) Review request for mesos, Alexander

Re: Review Request 41613: Added `DEFAULT_ROLE` constant to persistent volume tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41613/ --- (Updated Sept. 21, 2016, 3:35 p.m.) Review request for mesos, Alexander

Re: Review Request 41613: Added `DEFAULT_ROLE` constant to persistent volume tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41613/ --- (Updated Sept. 21, 2016, 3:33 p.m.) Review request for mesos, Alexander

Re: Review Request 41613: Added `DEFAULT_ROLE` constant to persistent volume tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41613/#review149807 --- src/tests/persistent_volume_tests.cpp (line 902)

Re: Review Request 41613: Added `DEFAULT_ROLE` constant to persistent volume tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41613/ --- (Updated Sept. 21, 2016, 5:55 a.m.) Review request for mesos, Alexander

Re: Review Request 41613: Added `DEFAULT_ROLE` constant to persistent volume tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41613/ --- (Updated July 8, 2016, 5:17 p.m.) Review request for mesos, Alexander

Re: Review Request 41613: Added `DEFAULT_ROLE` constant to persistent volume tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41613/ --- (Updated July 8, 2016, 5:16 p.m.) Review request for mesos, Alexander

Re: Review Request 41613: Added `DEFAULT_ROLE` constant to persistent volume tests.

> On May 3, 2016, 10:32 p.m., Michael Park wrote: > > src/tests/persistent_volume_tests.cpp, lines 573-575 > > > > > > ```cpp > > Resources taskResources = > > Resources::parse("cpus:1;mem:128;disk("

Re: Review Request 41613: Added `DEFAULT_ROLE` constant to persistent volume tests.

> On May 3, 2016, 10:32 p.m., Michael Park wrote: > > src/tests/persistent_volume_tests.cpp, line 68 > > > > > > Perhaps we should consider pulling this out to `src/tests/mesos.hpp`. Good call! I'll move this

Re: Review Request 41613: Added `DEFAULT_ROLE` constant to persistent volume tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41613/#review131557 --- Fix it, then Ship it! src/tests/persistent_volume_tests.cpp

Re: Review Request 41613: Added `DEFAULT_ROLE` constant to persistent volume tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41613/#review112801 --- Patch looks great! Reviews applied: [41613] Passed command:

Re: Review Request 41613: Added `DEFAULT_ROLE` constant to persistent volume tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41613/ --- (Updated Jan. 5, 2016, 2:49 a.m.) Review request for mesos, Alexander

Re: Review Request 41613: Added `DEFAULT_ROLE` constant to persistent volume tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41613/#review112752 --- Ship it! Ship It! - Guangya Liu On 一月 5, 2016, 2:49 a.m., Greg