Re: Review Request 42674: Replaced busybox with alpine in docker tests.

> On Jan. 25, 2016, 8:43 a.m., Bernd Mathiske wrote: > > src/tests/health_check_tests.cpp, line 351 > > > > > > Instead of naked strings we should reuse a constant that we can change > > in one place. I think I'll

Re: Review Request 42674: Replaced busybox with alpine in docker tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42674/#review116162 --- Ship it! Ship It! - Isabel Jimenez On Jan. 25, 2016, 7:18 p.

Re: Review Request 42674: Replaced busybox with alpine in docker tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42674/#review116149 --- Ship it! Ship It! - Jie Yu On Jan. 25, 2016, 7:18 p.m., Timo

Re: Review Request 42674: Replaced busybox with alpine in docker tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42674/ --- (Updated Jan. 25, 2016, 7:18 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 42674: Replaced busybox with alpine in docker tests.

> On Jan. 23, 2016, 5:40 p.m., Jie Yu wrote: > > Can you add more context in the description? Is that because there are too > > many links in busybox, causing issues with docker with brfts backend snce > > brfts backend has a limit on links? > > > > Also, can you do a sweep in the code base to

Re: Review Request 42674: Replaced busybox with alpine in docker tests.

> On 一月 23, 2016, 5:40 p.m., Jie Yu wrote: > > Can you add more context in the description? Is that because there are too > > many links in busybox, causing issues with docker with brfts backend snce > > brfts backend has a limit on links? > > > > Also, can you do a sweep in the code base to m

Re: Review Request 42674: Replaced busybox with alpine in docker tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42674/#review116064 --- src/tests/health_check_tests.cpp (line 351)

Re: Review Request 42674: Replaced busybox with alpine in docker tests.

> On Jan. 23, 2016, 9:40 a.m., Jie Yu wrote: > > Can you add more context in the description? Is that because there are too > > many links in busybox, causing issues with docker with brfts backend snce > > brfts backend has a limit on links? > > > > Also, can you do a sweep in the code base to

Re: Review Request 42674: Replaced busybox with alpine in docker tests.

> On 一月 23, 2016, 5:40 p.m., Jie Yu wrote: > > Can you add more context in the description? Is that because there are too > > many links in busybox, causing issues with docker with brfts backend snce > > brfts backend has a limit on links? > > > > Also, can you do a sweep in the code base to m

Re: Review Request 42674: Replaced busybox with alpine in docker tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42674/#review115996 --- Patch looks great! Reviews applied: [42674] Passed command: expo

Re: Review Request 42674: Replaced busybox with alpine in docker tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42674/#review115992 --- Can you add more context in the description? Is that because there

Re: Review Request 42674: Replaced busybox with alpine in docker tests.

> On 一月 23, 2016, 1 a.m., Guangya Liu wrote: > > I saw that many test cases are using busybox, why only updating this one's > > image? Is it possible to update all busybox to alpine? As the alpine was > > built around musl libc and BusyBox. The image is only 5 MB in size and has > > access to

Re: Review Request 42674: Replaced busybox with alpine in docker tests.

> On Jan. 23, 2016, 12:14 a.m., Isabel Jimenez wrote: > > src/tests/health_check_tests.cpp, line 351 > > > > > > Why can't we be consistent and use the official alpine image here too? Sorry that was a mistake. - T

Re: Review Request 42674: Replaced busybox with alpine in docker tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42674/ --- (Updated Jan. 23, 2016, 1:26 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 42674: Replaced busybox with alpine in docker tests.

> On Jan. 23, 2016, 1 a.m., Guangya Liu wrote: > > I saw that many test cases are using busybox, why only updating this one's > > image? Is it possible to update all busybox to alpine? As the alpine was > > built around musl libc and BusyBox. The image is only 5 MB in size and has > > access t

Re: Review Request 42674: Replaced busybox with alpine in docker tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42674/#review115959 --- I saw that many test cases are using busybox, why only updating th

Re: Review Request 42674: Replaced busybox with alpine in docker tests.

> On Jan. 23, 2016, 12:14 a.m., Isabel Jimenez wrote: > > +1 for this change. Alpine is great. - Isabel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42674/#review115956 ---

Re: Review Request 42674: Replaced busybox with alpine in docker tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42674/#review115956 --- src/tests/health_check_tests.cpp (line 351)

Review Request 42674: Replaced busybox with alpine in docker tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42674/ --- Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Jie Yu. Reposit