Re: Review Request 44258: Fixed http endpoint trigger two inverse offer calls.

2016-03-10 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44258/#review123064 --- Ship it! Ship It! - Joris Van Remoortere On March 9, 2016,

Re: Review Request 44258: Fixed http endpoint trigger two inverse offer calls.

2016-03-08 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44258/ --- (Updated 三月 9, 2016, 5:38 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 44258: Fixed http endpoint trigger two inverse offer calls.

2016-03-08 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44258/ --- (Updated 三月 9, 2016, 1:47 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 44258: Fixed http endpoint trigger two inverse offer calls.

2016-03-08 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44258/#review122623 --- src/tests/master_maintenance_tests.cpp (line 481)

Re: Review Request 44258: Fixed http endpoint trigger two inverse offer calls.

2016-03-08 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44258/#review122610 --- Ship it! Ship It! - Joseph Wu On March 4, 2016, 5:23 p.m.,

Re: Review Request 44258: Fixed http endpoint trigger two inverse offer calls.

2016-03-04 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44258/ --- (Updated March 5, 2016, 1:23 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 44258: Fixed http endpoint trigger two inverse offer calls.

2016-03-04 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44258/#review122161 --- src/master/http.cpp (lines 2029 - 2030)

Re: Review Request 44258: Fixed http endpoint trigger two inverse offer calls.

2016-03-04 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44258/ --- (Updated March 5, 2016, 12:34 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 44258: Fixed http endpoint trigger two inverse offer calls.

2016-03-04 Thread Guangya Liu
> On March 4, 2016, 8:28 p.m., Joris Van Remoortere wrote: > > src/master/http.cpp, lines 2026-2027 > > > > > > Can you explain how machines going from `UP` to `DOWN` are handled in > > the next loop? > > I

Re: Review Request 44258: Fixed http endpoint trigger two inverse offer calls.

2016-03-04 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44258/#review122146 --- src/master/http.cpp (line 2016)

Re: Review Request 44258: Fixed http endpoint trigger two inverse offer calls.

2016-03-03 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44258/ --- (Updated 三月 4, 2016, 2:10 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 44258: Fixed http endpoint trigger two inverse offer calls.

2016-03-03 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44258/#review121923 --- src/master/http.cpp (lines 1996 - 1999)

Re: Review Request 44258: Fixed http endpoint trigger two inverse offer calls.

2016-03-02 Thread Klaus Ma
> On March 2, 2016, 10:43 p.m., Klaus Ma wrote: > > src/master/http.cpp, lines 1999-2000 > > > > > > I think we can just remove `master->updateUnavailability(id, > > updated[id]);` here, so other machine will `UP`

Re: Review Request 44258: Fixed http endpoint trigger two inverse offer calls.

2016-03-02 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44258/ --- (Updated 三月 3, 2016, 6:05 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 44258: Fixed http endpoint trigger two inverse offer calls.

2016-03-02 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44258/#review121770 --- src/master/http.cpp (lines 1999 - 2000)

Re: Review Request 44258: Fixed http endpoint trigger two inverse offer calls.

2016-03-02 Thread Joseph Wu
> On March 2, 2016, 6:43 a.m., Klaus Ma wrote: > > src/master/http.cpp, lines 1999-2000 > > > > > > I think we can just remove `master->updateUnavailability(id, > > updated[id]);` here, so other machine will `UP`

Re: Review Request 44258: Fixed http endpoint trigger two inverse offer calls.

2016-03-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44258/#review121659 --- Patch looks great! Reviews applied: [44258] Passed command:

Re: Review Request 44258: Fixed http endpoint trigger two inverse offer calls.

2016-03-02 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44258/#review121643 --- src/master/http.cpp (lines 1999 - 2000)

Review Request 44258: Fixed http endpoint trigger two inverse offer calls.

2016-03-01 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44258/ --- Review request for mesos, Anand Mazumdar, Joris Van Remoortere, and Joseph Wu.