Re: Review Request 45360: Added volume driver client for mount and unmount.

2016-04-20 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45360/#review129812 --- Ship it! Guangya, I committed for you. I did a few tweaking on

Re: Review Request 45360: Added volume driver client for mount and unmount.

2016-04-20 Thread Jie Yu
> On April 19, 2016, 10:37 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/driver.hpp, line 41 > > > > > > Do you want to use `const Option& dvdcliPath` here? The idea is > > that if not

Re: Review Request 45360: Added volume driver client for mount and unmount.

2016-04-20 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45360/ --- (Updated 四月 20, 2016, 5:44 p.m.) Review request for mesos, David vonThenen, Gil

Re: Review Request 45360: Added volume driver client for mount and unmount.

2016-04-20 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45360/ --- (Updated 四月 20, 2016, 11:07 a.m.) Review request for mesos, David vonThenen, Gi

Re: Review Request 45360: Added volume driver client for mount and unmount.

2016-04-20 Thread Guangya Liu
> On 四月 5, 2016, 4:55 p.m., haosdent huang wrote: > > src/slave/containerizer/mesos/isolators/docker/dvd/dvd_client.cpp, line 59 > > > > > > Do we need check `dvdcli` version or something first? > > Guangya Liu wrote

Re: Review Request 45360: Added volume driver client for mount and unmount.

2016-04-20 Thread Guangya Liu
> On 四月 19, 2016, 10:37 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/driver.hpp, line 68 > > > > > > Why 'static'? If it's static, can that be a file local helper in > > driver.cpp? >

Re: Review Request 45360: Added volume driver client for mount and unmount.

2016-04-20 Thread Guangya Liu
> On 四月 14, 2016, 10:41 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/volume_client.hpp, > > line 46 > > > > > > Why virtual? Let's not make them virtual yet. I was following the dock

Re: Review Request 45360: Added volume driver client for mount and unmount.

2016-04-20 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45360/ --- (Updated 四月 20, 2016, 9:25 a.m.) Review request for mesos, David vonThenen, Gil

Re: Review Request 45360: Added volume driver client for mount and unmount.

2016-04-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45360/#review129712 --- Patch looks great! Reviews applied: [46245, 45373, 45326, 45270,

Re: Review Request 45360: Added volume driver client for mount and unmount.

2016-04-20 Thread Guangya Liu
> On 四月 19, 2016, 10:37 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/driver.hpp, line 41 > > > > > > Do you want to use `const Option& dvdcliPath` here? The idea is > > that if not sp

Re: Review Request 45360: Added volume driver client for mount and unmount.

2016-04-19 Thread Guangya Liu
> On 四月 19, 2016, 10:37 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/driver.hpp, line 41 > > > > > > Do you want to use `const Option& dvdcliPath` here? The idea is > > that if not sp

Re: Review Request 45360: Added volume driver client for mount and unmount.

2016-04-19 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45360/#review129573 --- src/Makefile.am (line 687)

Re: Review Request 45360: Added volume driver client for mount and unmount.

2016-04-15 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45360/ --- (Updated 四月 15, 2016, 2:43 p.m.) Review request for mesos, David vonThenen, Gil