Re: Review Request 45375: Implemented cleanup() for docker volume isolator.

> On 四月 24, 2016, 5:49 p.m., Gilbert Song wrote: > > This patch looks good to me. Almost ship it! > > > > Just one concern: > > > > Should we move the ref count logic out if we decide the future default > > behavior without ref count? then, add ref count logic together with the > > agent

Re: Review Request 45375: Implemented cleanup() for docker volume isolator.

> On 四月 24, 2016, 5:47 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp, lines > > 418-419 > > > > > > containerDir contains the containerId, right? Yes, but seems

Re: Review Request 45375: Implemented cleanup() for docker volume isolator.

> On 四月 24, 2016, 5:49 p.m., Gilbert Song wrote: > > This patch looks good to me. Almost ship it! > > > > Just one concern: > > > > Should we move the ref count logic out if we decide the future default > > behavior without ref count? then, add ref count logic together with the > > agent

Re: Review Request 45375: Implemented cleanup() for docker volume isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45375/#review130316 --- Ship it! Ship It! - Jie Yu On April 24, 2016, 9:50 a.m.,

Re: Review Request 45375: Implemented cleanup() for docker volume isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45375/#review130314 --- This patch looks good to me. Almost ship it! Just one concern:

Re: Review Request 45375: Implemented cleanup() for docker volume isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45375/#review130313 ---

Re: Review Request 45375: Implemented cleanup() for docker volume isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45375/#review130312 ---

Re: Review Request 45375: Implemented cleanup() for docker volume isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45375/ --- (Updated 四月 24, 2016, 9:50 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 45375: Implemented cleanup() for docker volume isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45375/ --- (Updated 四月 23, 2016, 7:58 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 45375: Implemented cleanup() for docker volume isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45375/#review130193 ---

Re: Review Request 45375: Implemented cleanup() for docker volume isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45375/ --- (Updated 四月 22, 2016, 4:13 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 45375: Implemented cleanup() for docker volume isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45375/ --- (Updated 四月 22, 2016, 7:08 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 45375: Implemented cleanup() for docker volume isolator.

> On 四月 22, 2016, 1:04 a.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp, lines > > 378-380 > > > > > > Seems like we should capture the first `:` here. Otherwise, we

Re: Review Request 45375: Implemented cleanup() for docker volume isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45375/#review129968 ---

Re: Review Request 45375: Implemented cleanup() for docker volume isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45375/#review129859 --- Patch looks great! Reviews applied: [46245, 45373, 45326, 45270,

Re: Review Request 45375: Implemented cleanup() for docker volume isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45375/ --- (Updated 四月 21, 2016, 3:43 a.m.) Review request for mesos, Gilbert Song and