Re: Review Request 45546: Implemented status() method of "network/cni" isolator.

> On April 3, 2016, 2:42 a.m., Jie Yu wrote: > > Qian, I followed up with a patch here. Please review it: > > https://reviews.apache.org/r/45620/ Jie, I have posted my comments on that patch. BTW, for this patch, it seems it has been submitted, so can you please mark it as submitted here? -

Re: Review Request 45546: Implemented status() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45546/#review126698 --- Qian, I followed up with a patch here. Please review it:

Re: Review Request 45546: Implemented status() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45546/#review126696 --- Ship it! Ship It! - Jie Yu On April 2, 2016, 3:18 a.m.,

Re: Review Request 45546: Implemented status() method of "network/cni" isolator.

> On April 2, 2016, 6:32 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp, lines 93-95 > > > > > > This is very confusing. We have both 'network' and 'networkInfo' in > >

Re: Review Request 45546: Implemented status() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45546/ --- (Updated April 2, 2016, 11:18 a.m.) Review request for mesos, Avinash

Re: Review Request 45546: Implemented status() method of "network/cni" isolator.

> On April 2, 2016, 6:32 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp, lines 93-95 > > > > > > This is very confusing. We have both 'network' and 'networkInfo' in > >

Re: Review Request 45546: Implemented status() method of "network/cni" isolator.

> On April 1, 2016, 10:32 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp, lines 93-95 > > > > > > This is very confusing. We have both 'network' and 'networkInfo' in > >

Re: Review Request 45546: Implemented status() method of "network/cni" isolator.

> On April 2, 2016, 6:32 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp, lines 93-95 > > > > > > This is very confusing. We have both 'network' and 'networkInfo' in > >

Re: Review Request 45546: Implemented status() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45546/#review126659 --- src/slave/containerizer/mesos/isolators/network/cni/cni.hpp

Re: Review Request 45546: Implemented status() method of "network/cni" isolator.

> On March 31, 2016, 6:31 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 786 > > > > > > Shouldn't we return a failure? > > Qian Zhang wrote: > I think we

Re: Review Request 45546: Implemented status() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45546/ --- (Updated April 1, 2016, 10:17 p.m.) Review request for mesos, Avinash

Re: Review Request 45546: Implemented status() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45546/ --- (Updated April 1, 2016, 5:53 p.m.) Review request for mesos, Avinash

Re: Review Request 45546: Implemented status() method of "network/cni" isolator.

> On April 1, 2016, 6:04 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 791-792 > > > > > > hum, what about labels and groups in NetworkInfo? I think we should > > save a

Re: Review Request 45546: Implemented status() method of "network/cni" isolator.

> On April 1, 2016, 2:31 a.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 786 > > > > > > Shouldn't we return a failure? I think we should not return a failure

Re: Review Request 45546: Implemented status() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45546/#review126469 --- src/slave/containerizer/mesos/isolators/network/cni/cni.cpp

Re: Review Request 45546: Implemented status() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45546/#review126388 --- Fix it, then Ship it! Ship It!

Re: Review Request 45546: Implemented status() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45546/#review126376 --- Patch looks great! Reviews applied: [44004, 44200, 44549, 44555,

Review Request 45546: Implemented status() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45546/ --- Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu. Bugs: