Re: Review Request 46471: Updated descriptions for master endpoints which may return redirect.

2016-04-22 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46471/ --- (Updated April 22, 2016, 4:40 p.m.) Review request for mesos, Adam B, Anand

Re: Review Request 46471: Updated descriptions for master endpoints which may return redirect.

2016-04-22 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46471/#review130112 --- Fix it, then Ship it! Ship It! src/master/http.cpp (line

Re: Review Request 46471: Updated descriptions for master endpoints which may return redirect.

2016-04-22 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46471/ --- (Updated April 22, 2016, 4:11 p.m.) Review request for mesos, Adam B, Anand

Re: Review Request 46471: Updated descriptions for master endpoints which may return redirect.

2016-04-22 Thread haosdent huang
> On April 22, 2016, 3:11 p.m., Neil Conway wrote: > > > > haosdent huang wrote: > Hi, @neilc. Thank you very much for your detail comments! I saw you use > `is xxed` in some comments while use `was xxed` in others. Should I change > all of them to `was xxed` to keep consistent? > > Neil

Re: Review Request 46471: Updated descriptions for master endpoints which may return redirect.

2016-04-22 Thread Neil Conway
> On April 22, 2016, 3:11 p.m., Neil Conway wrote: > > > > haosdent huang wrote: > Hi, @neilc. Thank you very much for your detail comments! I saw you use > `is xxed` in some comments while use `was xxed` in others. Should I change > all of them to `was xxed` to keep consistent? Good

Re: Review Request 46471: Updated descriptions for master endpoints which may return redirect.

2016-04-22 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46471/ --- (Updated April 22, 2016, 3:48 p.m.) Review request for mesos, Adam B, Anand

Re: Review Request 46471: Updated descriptions for master endpoints which may return redirect.

2016-04-22 Thread Neil Conway
> On April 22, 2016, 3:11 p.m., Neil Conway wrote: > > src/master/http.cpp, line 1307 > > > > > > "Returns 200 OK when the weight update was successful." > > haosdent huang wrote: > Should it be `the weights

Re: Review Request 46471: Updated descriptions for master endpoints which may return redirect.

2016-04-22 Thread haosdent huang
> On April 22, 2016, 3:11 p.m., Neil Conway wrote: > > Hi, @neilc. Thank you very much for your detail comments! I saw you use `is xxed` in some comments while use `was xxed` in others. Should I change all of them to `was xxed` to keep consistent? - haosdent

Re: Review Request 46471: Updated descriptions for master endpoints which may return redirect.

2016-04-22 Thread haosdent huang
> On April 22, 2016, 3:11 p.m., Neil Conway wrote: > > src/master/http.cpp, line 1307 > > > > > > "Returns 200 OK when the weight update was successful." Should it be `the weights update` here? - haosdent

Re: Review Request 46471: Updated descriptions for master endpoints which may return redirect.

2016-04-22 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46471/#review130099 --- src/master/http.cpp (line 335)

Re: Review Request 46471: Updated descriptions for master endpoints which may return redirect.

2016-04-22 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46471/ --- (Updated April 22, 2016, 7:18 a.m.) Review request for mesos, Adam B, Anand

Re: Review Request 46471: Updated descriptions for master endpoints which may return redirect.

2016-04-21 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46471/ --- (Updated April 22, 2016, 4:10 a.m.) Review request for mesos, Adam B, Anand

Re: Review Request 46471: Updated descriptions for master endpoints which may return redirect.

2016-04-21 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46471/#review130004 --- src/master/http.cpp (line 335)

Review Request 46471: Updated descriptions for master endpoints which may return redirect.

2016-04-20 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46471/ --- Review request for mesos, Adam B, Anand Mazumdar, Cody Maloney, Ian Downes,