According to the initial comment "A workaround for systems that have an old
glib but have a new kernel" made by Ian, I am not sure which version of
glib is old and which version of kernel if new.
At the previous commit, we included a syscall.h to fix this issue[1], but I
am not sure this is the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46610/#review130668
---
Ship it!
Since this followed the existing approach (used by
Thank you for you quick reply! `src/linux/fs.cpp` only effective under
Linux, so I think @Tomasz's patch should be fine. I verify add
```
#include
```
works on Ubuntu 14.04, CentOS 6, CentOS 7.
Anyway, let's see what others concerns after @Tomasz find a shepherd. Thank
you all!
On Mon, Apr
Hi @idownes and @chenzhiwei. @Tomasz proposal to add the correct header
file `` for pivot_root syscall. According my understand, we
could drop these workaround code:
```
#elif __x86_64__
// A workaround for systems that have an old glib but have a new
// kernel. The magic number '155' is the
> On April 24, 2016, 12:40 p.m., haosdent huang wrote:
> >
>
> haosdent huang wrote:
> In additional, could you add @chenzhiwei and @vinodkone in reviewers? I
> think powerpc could drop
>
> ```
> #elif __powerpc__ || __ppc__ || __powerpc64__ || __ppc64__
> // A
> On April 24, 2016, 12:40 p.m., haosdent huang wrote:
> >
>
> haosdent huang wrote:
> In additional, could you add @chenzhiwei and @vinodkone in reviewers? I
> think powerpc could drop
>
> ```
> #elif __powerpc__ || __ppc__ || __powerpc64__ || __ppc64__
> // A
> On April 24, 2016, 12:40 p.m., haosdent huang wrote:
> >
>
> haosdent huang wrote:
> In additional, could you add @chenzhiwei and @vinodkone in reviewers? I
> think powerpc could drop
>
> ```
> #elif __powerpc__ || __ppc__ || __powerpc64__ || __ppc64__
> // A
> On April 24, 2016, 12:40 p.m., haosdent huang wrote:
> >
>
> haosdent huang wrote:
> In additional, could you add @chenzhiwei and @vinodkone in reviewers? I
> think powerpc could drop
>
> ```
> #elif __powerpc__ || __ppc__ || __powerpc64__ || __ppc64__
> // A
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46610/#review130305
---
Patch looks great!
Reviews applied: [46610]
Passed command:
> On April 24, 2016, 12:40 p.m., haosdent huang wrote:
> >
In additional, could you add @chenzhiwei and @vinodkone in reviewers? I think
powerpc could drop
```
#elif __powerpc__ || __ppc__ || __powerpc64__ || __ppc64__
// A workaround for powerpc. The magic number '203' is the syscall
//
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46610/#review130303
---
src/linux/fs.cpp (line 442)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46610/
---
Review request for mesos and haosdent huang.
Repository: mesos
Description
12 matches
Mail list logo
