Re: Review Request 46824: Fully qualified addresses of Flag members in add calls.

> On Oct. 18, 2016, 11:22 a.m., Michael Park wrote: > > I'll just make the adjustments below when I commit it. Please let me know > > if you're against any of them. Thanks for the careful review. Your suggested adjustments are needed, +1. - Benjamin

Re: Review Request 46824: Fully qualified addresses of Flag members in add calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46824/#review153055 --- Fix it, then Ship it! I'll just make the adjustments below

Re: Review Request 46824: Fully qualified addresses of Flag members in add calls.

> On Oct. 18, 2016, 9:54 a.m., Michael Park wrote: > > src/local/main.cpp, lines 48-63 > > > > > > Is there a reason why we don't just add this directly to `local::Flags`? `local::Flags` is used in some other

Re: Review Request 46824: Fully qualified addresses of Flag members in add calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46824/ --- (Updated Oct. 18, 2016, 10:39 a.m.) Review request for mesos, Alexander

Re: Review Request 46824: Fully qualified addresses of Flag members in add calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46824/#review153049 --- src/local/main.cpp (lines 48 - 63)

Re: Review Request 46824: Fully qualified addresses of Flag members in add calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46824/ --- (Updated Oct. 17, 2016, 5:24 p.m.) Review request for mesos, Alexander

Re: Review Request 46824: Fully qualified addresses of Flag members in add calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46824/ --- (Updated Oct. 6, 2016, 4:59 p.m.) Review request for mesos, Alexander

Re: Review Request 46824: Fully qualified addresses of Flag members in add calls.

> On May 11, 2016, 11:27 p.m., Vinod Kone wrote: > > src/master/main.cpp, line 131 > > > > > > If `add` should be only called by derived classes, should `add` method > > be protected instead of public? > >

Re: Review Request 46824: Fully qualified addresses of Flag members in add calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46824/ --- (Updated Sept. 29, 2016, 2:55 p.m.) Review request for mesos, Alexander

Re: Review Request 46824: Fully qualified addresses of Flag members in add calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46824/ --- (Updated Aug. 30, 2016, 4:36 p.m.) Review request for mesos, Alexander

Re: Review Request 46824: Fully qualified addresses of Flag members in add calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46824/ --- (Updated Aug. 11, 2016, 6:32 p.m.) Review request for mesos, Alexander

Re: Review Request 46824: Fully qualified addresses of Flag members in add calls.

> On May 11, 2016, 11:27 p.m., Vinod Kone wrote: > > src/local/main.cpp, lines 52-53 > > > > > > why the need for "::" prefix here? There appears to be no need for it; remove here and elsewhere. > On May 11, 2016,

Re: Review Request 46824: Fully qualified addresses of Flag members in add calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46824/ --- (Updated July 5, 2016, 10:33 a.m.) Review request for mesos, Alexander

Re: Review Request 46824: Fully qualified addresses of Flag members in add calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46824/ --- (Updated July 5, 2016, 9:41 a.m.) Review request for mesos, Alexander

Re: Review Request 46824: Fully qualified addresses of Flag members in add calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46824/ --- (Updated July 5, 2016, 1:13 a.m.) Review request for mesos, Alexander

Re: Review Request 46824: Fully qualified addresses of Flag members in add calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46824/ --- (Updated July 4, 2016, 2:41 p.m.) Review request for mesos, Alexander

Re: Review Request 46824: Fully qualified addresses of Flag members in add calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46824/ --- (Updated July 3, 2016, 5:22 p.m.) Review request for mesos, Alexander

Re: Review Request 46824: Fully qualified addresses of Flag members in add calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46824/#review132750 --- src/examples/test_http_framework.cpp (line 381)

Re: Review Request 46824: Fully qualified addresses of Flag members in add calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46824/ --- (Updated May 11, 2016, 2:14 p.m.) Review request for mesos, Alexander

Re: Review Request 46824: Fully qualified addresses of Flag members in add calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46824/ --- (Updated April 29, 2016, 1:12 p.m.) Review request for mesos, Alexander

Review Request 46824: Fully qualified addresses of Flag members in add calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46824/ --- Review request for mesos, Alexander Rukletsov and Vinod Kone. Bugs: MESOS-3335