Re: Review Request 48046: Implement v1::master::Call::GET_TASKS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48046/ --- (Updated June 18, 2016, 2:33 a.m.) Review request for mesos, Anand Mazumdar, ha

Re: Review Request 48046: Implement v1::master::Call::GET_TASKS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48046/#review138337 --- Ship it! Ship It! - Vinod Kone On June 17, 2016, 6:59 a.m.,

Re: Review Request 48046: Implement v1::master::Call::GET_TASKS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48046/ --- (Updated June 17, 2016, 6:56 a.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 48046: Implement v1::master::Call::GET_TASKS.

> On June 17, 2016, 6:07 a.m., haosdent huang wrote: > > src/master/http.cpp, line 1447 > > > > > > How about change > > ``` > > message GetTasks { > > optional string limit = 1; > > option

Re: Review Request 48046: Implement v1::master::Call::GET_TASKS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48046/#review138171 --- src/master/http.cpp (line 1445)

Re: Review Request 48046: Implement v1::master::Call::GET_TASKS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48046/#review138166 --- src/master/http.cpp (line 1442)

Re: Review Request 48046: Implement v1::master::Call::GET_TASKS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48046/#review138165 --- src/master/http.cpp (line 1445)

Re: Review Request 48046: Implement v1::master::Call::GET_TASKS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48046/ --- (Updated June 17, 2016, 5:47 a.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 48046: Implement v1::master::Call::GET_TASKS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48046/#review138138 --- src/master/master.hpp (line 1317)

Re: Review Request 48046: Implement v1::master::Call::GET_TASKS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48046/#review137117 --- Ping. I don't think it is necessary to devolve protobuf in this AP

Re: Review Request 48046: Implement v1::master::Call::GET_TASKS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48046/ --- (Updated June 9, 2016, 11:17 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 48046: Implement v1::master::Call::GET_TASKS.

> On June 9, 2016, 9:26 p.m., Vinod Kone wrote: > > src/tests/api_tests.cpp, line 171 > > > > > > What does this comment mean? I didn't follow. > > > > Also, comments should start with a capital letter and e

Re: Review Request 48046: Implement v1::master::Call::GET_TASKS.

> On June 9, 2016, 9:26 p.m., Vinod Kone wrote: > > src/tests/api_tests.cpp, line 171 > > > > > > What does this comment mean? I didn't follow. > > > > Also, comments should start with a capital letter and e

Re: Review Request 48046: Implement v1::master::Call::GET_TASKS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48046/#review136822 --- src/master/http.cpp (line 645)

Re: Review Request 48046: Implement v1::master::Call::GET_TASKS.

> On June 9, 2016, 6:20 p.m., haosdent huang wrote: > > Hi, @guoger. Now the return type of RPC handlers become > > process::http::Response, may you rebase your patch? Good job! working on it! - Jay --- This is an automatically generat

Re: Review Request 48046: Implement v1::master::Call::GET_TASKS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48046/#review136867 --- Hi, @guoger. Now the return type of RPC handlers become process::

Re: Review Request 48046: Implement v1::master::Call::GET_TASKS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48046/ --- (Updated June 9, 2016, 12:49 a.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 48046: Implement v1::master::Call::GET_TASKS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48046/ --- (Updated June 9, 2016, 12:01 a.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 48046: Implement v1::master::Call::GET_TASKS.

> On June 8, 2016, 5:34 p.m., Vinod Kone wrote: > > src/master/http.cpp, lines 1390-1411 > > > > > > so this stuff is duplicated in the REST handler and this handler. i > > wonder if we can factor it out as well in

Re: Review Request 48046: Implement v1::master::Call::GET_TASKS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48046/#review136664 --- src/master/http.cpp (lines 1390 - 1411)

Re: Review Request 48046: Implement v1::master::Call::GET_TASKS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48046/#review136608 --- Patch looks great! Reviews applied: [48400, 48401, 48046] Passed

Re: Review Request 48046: Implement v1::master::Call::GET_TASKS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48046/ --- (Updated June 8, 2016, 7:18 a.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 48046: Implement v1::master::Call::GET_TASKS.

> On May 30, 2016, 6:44 p.m., Vinod Kone wrote: > > src/master/http.cpp, lines 2420-2423 > > > > > > this will have a performance regression for /tasks. > > > > I would say for now don't touch tasks(). Just

Re: Review Request 48046: Implement v1::master::Call::GET_TASKS.

> On June 7, 2016, 5:15 p.m., Vinod Kone wrote: > > Any updates on this? I'm working on it now and will submit a patch later today - Jay --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48046/

Re: Review Request 48046: Implement v1::master::Call::GET_TASKS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48046/#review136495 --- Any updates on this? - Vinod Kone On May 30, 2016, 4:23 p.m., J

Re: Review Request 48046: Implement v1::master::Call::GET_TASKS.

> On May 30, 2016, 6:44 p.m., Vinod Kone wrote: > > src/master/http.cpp, lines 2420-2423 > > > > > > this will have a performance regression for /tasks. > > > > I would say for now don't touch tasks(). Just

Re: Review Request 48046: Implement v1::master::Call::GET_TASKS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48046/#review135536 --- Patch looks great! Reviews applied: [48046] Passed command: expo

Re: Review Request 48046: Implement v1::master::Call::GET_TASKS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48046/#review135531 --- src/internal/evolve.hpp

Review Request 48046: Implement v1::master::Call::GET_TASKS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48046/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5493 https://issues.ap