Re: Review Request 48585: Devolved v1 operator protos to unversioned operator protos in Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48585/#review137836 --- Ship it! Ship It! - Vinod Kone On June 15, 2016, 2:26 p.m.,

Re: Review Request 48585: Devolved v1 operator protos to unversioned operator protos in Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48585/ --- (Updated June 15, 2016, 2:26 p.m.) Review request for mesos, Anand Mazumdar, zh

Re: Review Request 48585: Devolved v1 operator protos to unversioned operator protos in Master.

> On June 13, 2016, 10:07 p.m., Vinod Kone wrote: > > src/master/http.cpp, lines 596-632 > > > > > > s/mesos::// > > Anand Mazumdar wrote: > I guess @haosdent had to add them due to there being an already existi

Re: Review Request 48585: Devolved v1 operator protos to unversioned operator protos in Master.

> On June 13, 2016, 10:07 p.m., Vinod Kone wrote: > > src/master/http.cpp, lines 596-632 > > > > > > s/mesos::// > > Anand Mazumdar wrote: > I guess @haosdent had to add them due to there being an already existi

Re: Review Request 48585: Devolved v1 operator protos to unversioned operator protos in Master.

> On June 13, 2016, 10:07 p.m., Vinod Kone wrote: > > src/master/http.cpp, lines 596-632 > > > > > > s/mesos::// > > Anand Mazumdar wrote: > I guess @haosdent had to add them due to there being an already existi

Re: Review Request 48585: Devolved v1 operator protos to unversioned operator protos in Master.

> On June 13, 2016, 10:07 p.m., Vinod Kone wrote: > > src/master/http.cpp, lines 596-632 > > > > > > s/mesos::// I guess @haosdent had to add them due to there being an already existing `master` namespace in our co

Re: Review Request 48585: Devolved v1 operator protos to unversioned operator protos in Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48585/#review137403 --- src/master/http.cpp (line 573)

Re: Review Request 48585: Devolved v1 operator protos to unversioned operator protos in Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48585/ --- (Updated June 12, 2016, 6:01 p.m.) Review request for mesos, Anand Mazumdar, zh

Re: Review Request 48585: Devolved v1 operator protos to unversioned operator protos in Master.

> On June 12, 2016, 5:15 a.m., Anand Mazumdar wrote: > > LGTM.. Just a few more nits to clean up... Thanks a lot for your reviews! I fix the issues you mentioned in https://reviews.apache.org/r/48588/ as well. May you help review this and it again? Thank you in advance. - haosdent

Re: Review Request 48585: Devolved v1 operator protos to unversioned operator protos in Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48585/ --- (Updated June 12, 2016, 5:55 a.m.) Review request for mesos, Anand Mazumdar, zh

Re: Review Request 48585: Devolved v1 operator protos to unversioned operator protos in Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48585/#review137149 --- Fix it, then Ship it! LGTM.. Just a few more nits to clean up..

Re: Review Request 48585: Devolved v1 operator protos to unversioned operator protos in Master.

> On June 11, 2016, 8:33 p.m., Anand Mazumdar wrote: > > src/internal/evolve.hpp, lines 120-121 > > > > > > It's fine to evolve `JSON::Object` directly into `v1` to avoid making > > an extra copy. We adopted a simil

Re: Review Request 48585: Devolved v1 operator protos to unversioned operator protos in Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48585/ --- (Updated June 12, 2016, 4:15 a.m.) Review request for mesos, Anand Mazumdar, zh

Re: Review Request 48585: Devolved v1 operator protos to unversioned operator protos in Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48585/#review137137 --- LGTM overall. Minor comments around evolving `Response` to `v1::Re

Re: Review Request 48585: Devolved v1 operator protos to unversioned operator protos in Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48585/ --- (Updated June 11, 2016, 6:42 p.m.) Review request for mesos, Anand Mazumdar, zh

Re: Review Request 48585: Devolved v1 operator protos to unversioned operator protos in Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48585/#review137130 --- Patch looks great! Reviews applied: [48583, 48584, 48585] Passed

Re: Review Request 48585: Devolved v1 operator protos to unversioned operator protos in Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48585/#review137128 --- src/internal/evolve.cpp (line 445)

Review Request 48585: Devolved v1 operator protos to unversioned operator protos in Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48585/ --- Review request for mesos, Anand Mazumdar, zhou xing, Jay Guo, and Vinod Kone. B