Re: Review Request 49228: Fixed wrong stopped time in webui for live tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49228/#review139664 --- Ship it! Ship It! - Vinod Kone On June 27, 2016, 9:05 p.m.,

Re: Review Request 49228: Fixed wrong stopped time in webui for live tasks.

> On June 27, 2016, 6:27 p.m., Vinod Kone wrote: > > src/webui/master/static/js/controllers.js, line 149 > > > > > > task.statuses[0] could be a terminal state if a task went directly from > > TASK_STAGING to TASK_L

Re: Review Request 49228: Fixed wrong stopped time in webui for live tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49228/ --- (Updated June 27, 2016, 9:05 p.m.) Review request for mesos, Benjamin Mahler, h

Re: Review Request 49228: Fixed wrong stopped time in webui for live tasks.

> On June 27, 2016, 6:27 p.m., Vinod Kone wrote: > > src/webui/master/static/js/controllers.js, line 149 > > > > > > task.statuses[0] could be a terminal state if a task went directly from > > TASK_STAGING to TASK_L

Re: Review Request 49228: Fixed wrong stopped time in webui for live tasks.

> On June 27, 2016, 6:27 p.m., Vinod Kone wrote: > > src/webui/master/static/js/controllers.js, line 149 > > > > > > task.statuses[0] could be a terminal state if a task went directly from > > TASK_STAGING to TASK_L

Re: Review Request 49228: Fixed wrong stopped time in webui for live tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49228/ --- (Updated June 27, 2016, 7:05 p.m.) Review request for mesos, Benjamin Mahler, h

Re: Review Request 49228: Fixed wrong stopped time in webui for live tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49228/#review139622 --- src/webui/master/static/js/controllers.js (line 149)

Re: Review Request 49228: Fixed wrong stopped time in webui for live tasks.

> On June 27, 2016, 5:28 p.m., haosdent huang wrote: > > src/webui/master/static/js/controllers.js, line 158 > > > > > > Not sure if `isTaskTerminated` is a better name. > > Tomasz Janiszewski wrote: > Definetel

Re: Review Request 49228: Fixed wrong stopped time in webui for live tasks.

> On June 27, 2016, 5:28 p.m., haosdent huang wrote: > > src/webui/master/static/js/controllers.js, line 158 > > > > > > Not sure if `isTaskTerminated` is a better name. Definetely it is. Fixed. - Tomasz ---

Re: Review Request 49228: Fixed wrong stopped time in webui for live tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49228/ --- (Updated June 27, 2016, 5:40 p.m.) Review request for mesos, Benjamin Mahler, h

Re: Review Request 49228: Fixed wrong stopped time in webui for live tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49228/#review139612 --- Patch looks great! Reviews applied: [49228] Passed command: expo

Re: Review Request 49228: Fixed wrong stopped time in webui for live tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49228/#review139606 --- src/webui/master/static/js/controllers.js (line 157)

Re: Review Request 49228: Fixed wrong stopped time in webui for live tasks.

> On June 27, 2016, 5:17 p.m., haosdent huang wrote: > > src/webui/master/static/js/controllers.js, line 158 > > > > > > `function (task)` should be `function(task)` Thanks. We should add jslint to this project as a

Re: Review Request 49228: Fixed wrong stopped time in webui for live tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49228/ --- (Updated June 27, 2016, 5:26 p.m.) Review request for mesos, Benjamin Mahler, h

Re: Review Request 49228: Fixed wrong stopped time in webui for live tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49228/#review139605 --- Fix it, then Ship it! Ship It! src/webui/master/static/js/con

Re: Review Request 49228: Fixed wrong stopped time in webui for live tasks.

> On June 25, 2016, 3:26 p.m., Tomasz Janiszewski wrote: > > src/webui/master/static/js/controllers.js, line 162 > > > > > > Probably `task.state` could be used here. > > Vinod Kone wrote: > yup. just use `task.

Re: Review Request 49228: Fixed wrong stopped time in webui for live tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49228/ --- (Updated June 27, 2016, 10:03 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 49228: Fixed wrong stopped time in webui for live tasks.

> On June 25, 2016, 3:26 p.m., Tomasz Janiszewski wrote: > > src/webui/master/static/js/controllers.js, line 162 > > > > > > Probably `task.state` could be used here. yup. just use `task.state` here - Vinod

Re: Review Request 49228: Fixed wrong stopped time in webui for live tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49228/#review139456 --- Patch looks great! Reviews applied: [49228] Passed command: expo

Re: Review Request 49228: Fixed wrong stopped time in webui for live tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49228/#review139446 --- src/webui/master/static/js/controllers.js (line 161)

Review Request 49228: Fixed wrong stopped time in webui for live tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49228/ --- Review request for mesos, Benjamin Mahler, haosdent huang, Ross Allen, and Vinod