Re: Review Request 49360: Supported TCP in health check.

2016-08-26 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49360/#review146946 --- Fix it, then Ship it! src/health-check/health_checker.cpp

Re: Review Request 49360: Supported TCP in health check.

2016-08-26 Thread Alexander Rukletsov
> On Aug. 25, 2016, 12:49 p.m., Tomasz Janiszewski wrote: > > src/health-check/health_checker.cpp, line 452 > > > > > > Will it work on all supported systems? > > haosdent huang wrote: > Windows also have bash

Re: Review Request 49360: Supported TCP in health check.

2016-08-25 Thread haosdent huang
> On Aug. 25, 2016, 12:49 p.m., Tomasz Janiszewski wrote: > > src/health-check/health_checker.cpp, line 452 > > > > > > Will it work on all supported systems? Windows also have bash now but require external

Re: Review Request 49360: Supported TCP in health check.

2016-08-25 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49360/ --- (Updated Aug. 25, 2016, 1:25 p.m.) Review request for mesos, Alexander

Re: Review Request 49360: Supported TCP in health check.

2016-08-25 Thread Tomasz Janiszewski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49360/#review146777 --- src/health-check/health_checker.cpp (line 452)

Re: Review Request 49360: Supported TCP in health check.

2016-08-25 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49360/ --- (Updated Aug. 25, 2016, 12:34 p.m.) Review request for mesos, Alexander

Re: Review Request 49360: Supported TCP in health check.

2016-08-24 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49360/ --- (Updated Aug. 24, 2016, 5:23 p.m.) Review request for mesos, Alexander

Re: Review Request 49360: Supported TCP in health check.

2016-08-24 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49360/ --- (Updated Aug. 24, 2016, 4:52 p.m.) Review request for mesos, Alexander

Re: Review Request 49360: Supported TCP in health check.

2016-08-24 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49360/ --- (Updated Aug. 24, 2016, 4:46 p.m.) Review request for mesos, Alexander

Re: Review Request 49360: Supported TCP in health check.

2016-08-17 Thread haosdent huang
> On Aug. 17, 2016, 12:05 a.m., Alexander Rukletsov wrote: > > src/health-check/health_checker.cpp, lines 489-503 > > > > > > Again, we probably want to do it in a subprocess hook. For this, we > > need to provide

Re: Review Request 49360: Supported TCP in health check.

2016-08-16 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49360/#review145935 --- src/health-check/health_checker.cpp (lines 489 - 503)

Re: Review Request 49360: Supported TCP in health check.

2016-08-15 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49360/ --- (Updated Aug. 15, 2016, 3:43 p.m.) Review request for mesos, Alexander

Re: Review Request 49360: Supported TCP in health check.

2016-08-14 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49360/ --- (Updated Aug. 14, 2016, 5:05 p.m.) Review request for mesos, Alexander