Re: Review Request 51625: Refactored `GET_CONTAINERS` Call in v1 Agent API.

2016-09-14 Thread haosdent huang
> On Sept. 12, 2016, 8:19 p.m., Vinod Kone wrote: > > Can you separate out filtering of containers and the refactor into separate > > commits? Ideally do filtering first. > > > > Also, what's the motivation for including containers in GetState? I > > couldn't get the motivation from the

Re: Review Request 51625: Refactored `GET_CONTAINERS` Call in v1 Agent API.

2016-09-12 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51625/#review148573 --- Can you separate out filtering of containers and the refactor

Re: Review Request 51625: Refactored `GET_CONTAINERS` Call in v1 Agent API.

2016-09-12 Thread haosdent huang
> On Sept. 5, 2016, 1:51 p.m., Vinod Kone wrote: > > src/slave/http.cpp, line 1863 > > > > > > It is unfortunate that you re-implemented `__containers()` here. Is it > > possible to factor out the implementation

Re: Review Request 51625: Refactored `GET_CONTAINERS` Call in v1 Agent API.

2016-09-12 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51625/ --- (Updated Sept. 12, 2016, 4:50 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 51625: Refactored `GET_CONTAINERS` Call in v1 Agent API.

2016-09-05 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51625/#review147762 --- src/slave/http.cpp (line 1869)

Re: Review Request 51625: Refactored `GET_CONTAINERS` Call in v1 Agent API.

2016-09-05 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51625/#review147754 --- src/slave/http.cpp

Re: Review Request 51625: Refactored `GET_CONTAINERS` Call in v1 Agent API.

2016-09-05 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51625/ --- (Updated Sept. 5, 2016, 9:46 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 51625: Refactored `GET_CONTAINERS` Call in v1 Agent API.

2016-09-04 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51625/ --- (Updated Sept. 4, 2016, 10:58 a.m.) Review request for mesos, Anand Mazumdar,

Review Request 51625: Refactored `GET_CONTAINERS` Call in v1 Agent API.

2016-09-04 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51625/ --- Review request for mesos, Anand Mazumdar, Jay Guo, Vinod Kone, and Zhitao Li.