Re: Review Request 52100: Added validation of NESTED_CONTAINER_* calls in the agent API.

2016-09-21 Thread Benjamin Mahler
> On Sept. 21, 2016, 2:39 a.m., Guangya Liu wrote: > > src/Makefile.am, line 2121 > > > > > > Just a question here: for the new added test files for agent, do we > > want to continue name it as slave_xxx_tests.cpp

Re: Review Request 52100: Added validation of NESTED_CONTAINER_* calls in the agent API.

2016-09-21 Thread Benjamin Mahler
> On Sept. 20, 2016, 11:48 p.m., Vinod Kone wrote: > > src/slave/validation.cpp, lines 117-127 > > > > > > so `UUID::fromBytes()` (used for status update uuids) doesn't impose a > > restriction on the version but we

Re: Review Request 52100: Added validation of NESTED_CONTAINER_* calls in the agent API.

2016-09-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52100/#review149803 --- Bad patch! Reviews applied: [52100, 52099, 52098, 52057, 52056, 5

Re: Review Request 52100: Added validation of NESTED_CONTAINER_* calls in the agent API.

2016-09-20 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52100/#review149783 --- src/Makefile.am (line 2121)

Re: Review Request 52100: Added validation of NESTED_CONTAINER_* calls in the agent API.

2016-09-20 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52100/#review149761 --- Fix it, then Ship it! LGTM modulo the names as mentioned in the

Review Request 52100: Added validation of NESTED_CONTAINER_* calls in the agent API.

2016-09-20 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52100/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-2449 https://issues.ap