----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52100/#review149783 -----------------------------------------------------------
src/Makefile.am (line 2121) <https://reviews.apache.org/r/52100/#comment217490> Just a question here: for the new added test files for agent, do we want to continue name it as slave_xxx_tests.cpp or agent_xxx_tests.cpp? src/slave/validation.cpp (line 112) <https://reviews.apache.org/r/52100/#comment217491> s/ContainerID/`ContainerID` Ditto here and elsewhere. src/slave/validation.cpp (line 129) <https://reviews.apache.org/r/52100/#comment217487> s/ContainerID/`ContainerID` - Guangya Liu On 九月 20, 2016, 9:28 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52100/ > ----------------------------------------------------------- > > (Updated 九月 20, 2016, 9:28 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-2449 > https://issues.apache.org/jira/browse/MESOS-2449 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/Makefile.am b6b64bc93980cb81fc50380835865af1f6e4e59f > src/slave/validation.cpp a9f318214182a87783a985cd8495a0ec00c95378 > src/tests/slave_validation_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/52100/diff/ > > > Testing > ------- > > Added tests. > > > Thanks, > > Benjamin Mahler > >
