----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52100/#review149761 -----------------------------------------------------------
Fix it, then Ship it! LGTM modulo the names as mentioned in the earlier review. src/slave/validation.cpp (lines 117 - 127) <https://reviews.apache.org/r/52100/#comment217463> so `UUID::fromBytes()` (used for status update uuids) doesn't impose a restriction on the version but we want to impose version restriction here? src/slave/validation.cpp (lines 117 - 127) <https://reviews.apache.org/r/52100/#comment217464> I would flip the order of these two. src/tests/slave_validation_tests.cpp (line 20) <https://reviews.apache.org/r/52100/#comment217465> new line? src/tests/slave_validation_tests.cpp (line 42) <https://reviews.apache.org/r/52100/#comment217466> shouldn't these be backticks? here and everywhere else? - Vinod Kone On Sept. 20, 2016, 9:28 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52100/ > ----------------------------------------------------------- > > (Updated Sept. 20, 2016, 9:28 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-2449 > https://issues.apache.org/jira/browse/MESOS-2449 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/Makefile.am b6b64bc93980cb81fc50380835865af1f6e4e59f > src/slave/validation.cpp a9f318214182a87783a985cd8495a0ec00c95378 > src/tests/slave_validation_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/52100/diff/ > > > Testing > ------- > > Added tests. > > > Thanks, > > Benjamin Mahler > >
