Re: Review Request 52671: Modified the `--network_cni_plugins_dir` flag.

2016-10-14 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52671/ --- (Updated Oct. 14, 2016, 4:01 p.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 52671: Modified the `--network_cni_plugins_dir` flag.

2016-10-13 Thread Avinash sridharan
> On Oct. 14, 2016, 4:34 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 198-209 > > > > > > Ditto. Yeah we actually don't need this anymore. Didn't realize `os::which`

Re: Review Request 52671: Modified the `--network_cni_plugins_dir` flag.

2016-10-13 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52671/#review152629 --- Fix it, then Ship it!

Re: Review Request 52671: Modified the `--network_cni_plugins_dir` flag.

2016-10-11 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52671/ --- (Updated Oct. 12, 2016, 5:49 a.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 52671: Modified the `--network_cni_plugins_dir` flag.

2016-10-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52671/#review151952 --- Patch looks great! Reviews applied: [52671] Passed command:

Review Request 52671: Modified the `--network_cni_plugins_dir` flag.

2016-10-09 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52671/ --- Review request for mesos, Jie Yu and Qian Zhang. Bugs: MESOS-6344