Re: Review Request 53791: Use the stout ELF parser to collect Linux rootfs files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53791/#review164243 --- Ship it! Ship It! - Jiang Yan Xu On Feb. 3, 2017, 4:44

Re: Review Request 53791: Use the stout ELF parser to collect Linux rootfs files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53791/#review164013 --- Patch looks great! Reviews applied: [53790, 54712, 54878, 53791]

Re: Review Request 53791: Use the stout ELF parser to collect Linux rootfs files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53791/ --- (Updated Feb. 2, 2017, 5:32 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 53791: Use the stout ELF parser to collect Linux rootfs files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53791/#review163947 --- Patch looks great! Reviews applied: [53790, 54712, 54878, 53791]

Re: Review Request 53791: Use the stout ELF parser to collect Linux rootfs files.

> On Feb. 1, 2017, 3:51 p.m., James Peach wrote: > > src/tests/containerizer/rootfs.cpp, line 90 > > > > > > What are you asking for here? This can fail for a number of reasons and > > `errno` describes them.

Re: Review Request 53791: Use the stout ELF parser to collect Linux rootfs files.

> On Feb. 1, 2017, 3:51 p.m., James Peach wrote: > > Could you directly reply to the comment in the future? It's pretty hard to follow with this format... > On Feb. 1, 2017, 3:51 p.m., James Peach wrote: > > src/tests/containerizer/rootfs.hpp, line 50 > >

Re: Review Request 53791: Use the stout ELF parser to collect Linux rootfs files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53791/#review163834 --- src/tests/containerizer/rootfs.hpp (line 50)

Re: Review Request 53791: Use the stout ELF parser to collect Linux rootfs files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53791/ --- (Updated Feb. 1, 2017, 11:51 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 53791: Use the stout ELF parser to collect Linux rootfs files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53791/#review163720 --- src/tests/containerizer/rootfs.hpp (line 21)

Re: Review Request 53791: Use the stout ELF parser to collect Linux rootfs files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53791/#review159711 --- Patch looks great! Reviews applied: [53790, 54712, 54878, 53791]

Re: Review Request 53791: Use the stout ELF parser to collect Linux rootfs files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53791/ --- (Updated Dec. 19, 2016, 11:24 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 53791: Use the stout ELF parser to collect Linux rootfs files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53791/#review159117 --- Patch looks great! Reviews applied: [53790, 54712, 53791]

Re: Review Request 53791: Use the stout ELF parser to collect Linux rootfs files.

> On Dec. 13, 2016, 11:13 a.m., Benjamin Bannier wrote: > > src/linux/ldd.cpp, lines 82-83 > > > > > > Let's move this up right after the check `needed.contains(path)`. > > > > Right now in pathological

Re: Review Request 53791: Use the stout ELF parser to collect Linux rootfs files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53791/#review159025 --- src/linux/ldd.cpp (line 37)

Re: Review Request 53791: Use the stout ELF parser to collect Linux rootfs files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53791/ --- (Updated Dec. 13, 2016, 6:34 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 53791: Use the stout ELF parser to collect Linux rootfs files.

> On Dec. 13, 2016, 10:13 a.m., Benjamin Bannier wrote: > > src/linux/ldd.cpp, line 32 > > > > > > Mesos does not like anon namespaces. Since this namespace e.g., > > declares no types, you could just replace its

Re: Review Request 53791: Use the stout ELF parser to collect Linux rootfs files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53791/#review158971 --- Thanks for looking into this James. Looks mostly good for me; I

Re: Review Request 53791: Use the stout ELF parser to collect Linux rootfs files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53791/ --- (Updated Nov. 29, 2016, 1:21 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 53791: Use the stout ELF parser to collect Linux rootfs files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53791/#review156407 --- src/Makefile.am (line 1042)

Re: Review Request 53791: Use the stout ELF parser to collect Linux rootfs files.

> On Nov. 18, 2016, 1:24 a.m., Jiang Yan Xu wrote: > > src/tests/containerizer/rootfs.cpp, line 58 > > > > > > This feels like an implementation of `ldd()` that coule be generally > > useful. > > > > Would

Re: Review Request 53791: Use the stout ELF parser to collect Linux rootfs files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53791/#review156374 --- Patch looks great! Reviews applied: [53790, 53791] Passed

Re: Review Request 53791: Use the stout ELF parser to collect Linux rootfs files.

> On Nov. 18, 2016, 1:24 a.m., Jiang Yan Xu wrote: > > src/tests/containerizer/rootfs.cpp, lines 81-84 > > > > > > If we have to do this, format it this way > > > > ``` > > auto entry = std::find_if( > >

Re: Review Request 53791: Use the stout ELF parser to collect Linux rootfs files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53791/ --- (Updated Nov. 18, 2016, 7:23 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 53791: Use the stout ELF parser to collect Linux rootfs files.

> On Nov. 18, 2016, 1:24 a.m., Jiang Yan Xu wrote: > > src/tests/containerizer/rootfs.cpp, line 234 > > > > > > Would the following look better? > > > > ``` > > hashset needed(programs.begin(),

Re: Review Request 53791: Use the stout ELF parser to collect Linux rootfs files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53791/#review156259 --- src/tests/containerizer/rootfs.cpp (line 58)

Re: Review Request 53791: Use the stout ELF parser to collect Linux rootfs files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53791/#review156100 --- Patch looks great! Reviews applied: [53790, 53791] Passed

Re: Review Request 53791: Use the stout ELF parser to collect Linux rootfs files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53791/ --- (Updated Nov. 15, 2016, 6:28 p.m.) Review request for mesos and Jiang Yan Xu.

Review Request 53791: Use the stout ELF parser to collect Linux rootfs files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53791/ --- Review request for mesos and Jiang Yan Xu. Bugs: MESOS-6588