Re: Review Request 54039: Added `recordio::transform` helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54039/ --- (Updated Nov. 29, 2016, 5:36 a.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 54039: Added `recordio::transform` helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54039/#review157172 --- Fix it, then Ship it! src/tests/common/recordio_tests.cpp (lin

Re: Review Request 54039: Added `recordio::transform` helper.

> On Nov. 28, 2016, 3:23 a.m., Anand Mazumdar wrote: > > src/common/recordio.hpp, line 112 > > > > > > hmm, this doesn't need to be an `Owned` here. Can we just use > > `Reader&& reader` instead? > > > > We

Re: Review Request 54039: Added `recordio::transform` helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54039/ --- (Updated Nov. 28, 2016, 6:48 a.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 54039: Added `recordio::transform` helper.

> On Nov. 27, 2016, 10:49 p.m., Anand Mazumdar wrote: > > src/common/recordio.hpp, lines 128-130 > > > > > > hmm, it's a bit unfortunate that we would _only_ notice a disconnection > > between the client and the age

Re: Review Request 54039: Added `recordio::transform` helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54039/#review156984 --- src/common/recordio.hpp (line 112)

Re: Review Request 54039: Added `recordio::transform` helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54039/#review156976 --- src/common/recordio.hpp (lines 128 - 130)

Re: Review Request 54039: Added `recordio::transform` helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54039/ --- (Updated Nov. 26, 2016, 5:41 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 54039: Added `recordio::transform` helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54039/ --- (Updated Nov. 23, 2016, 11:53 p.m.) Review request for mesos, Anand Mazumdar an

Re: Review Request 54039: Added `recordio::transform` helper.

> On Nov. 23, 2016, 9:15 p.m., Anand Mazumdar wrote: > > src/common/recordio.hpp, lines 101-103 > > > > > > You might want to reorder the arguments based on the comments above > > i.e., `Reader`, `func` (transformat

Re: Review Request 54039: Added `recordio::transform` helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54039/#review156776 --- Fix it, then Ship it! LGTM, just a few minor style nits to take

Review Request 54039: Added `recordio::transform` helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54039/ --- Review request for mesos, Anand Mazumdar and Benjamin Mahler. Bugs: MESOS-6473