Re: Review Request 56001: Fixed a few executor segfaults during cleanup.

2017-01-26 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56001/#review163211 --- Fix it, then Ship it! LGTM!

Re: Review Request 56001: Fixed a few executor segfaults during cleanup.

2017-01-26 Thread Joseph Wu
> On Jan. 26, 2017, 2:47 p.m., Anand Mazumdar wrote: > > src/docker/executor.cpp, line 817 > > > > > > Not yours, but we should have a comment here too as to why we need an > > explicit `finalize()` here in a

Re: Review Request 56001: Fixed a few executor segfaults during cleanup.

2017-01-26 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56001/ --- (Updated Jan. 26, 2017, 4:01 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 56001: Fixed a few executor segfaults during cleanup.

2017-01-26 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56001/#review163190 --- Nice catch! As per our offline discussion, can you modify an

Review Request 56001: Fixed a few executor segfaults during cleanup.

2017-01-26 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56001/ --- Review request for mesos, Anand Mazumdar, Gilbert Song, and Jie Yu. Bugs: