Re: Review Request 56218: Added a check test for default executor.

2017-03-20 Thread Alexander Rukletsov
> On March 17, 2017, 11:07 a.m., Vinod Kone wrote: > > src/tests/check_tests.cpp > > Lines 854 (patched) > > > > > > can you add a TODO to cleanup this file as follows: > > > > 1) Move variables closer to

Re: Review Request 56218: Added a check test for default executor.

2017-03-20 Thread Alexander Rukletsov
> On March 17, 2017, 11:07 a.m., Vinod Kone wrote: > > src/tests/check_tests.cpp > > Lines 846-848 (patched) > > > > > > dont you want to do these tests for HTTP as well? I think doing the same for HTTP would be

Re: Review Request 56218: Added a check test for default executor.

2017-03-17 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56218/#review169278 --- Fix it, then Ship it! src/tests/check_tests.cpp Lines 846-848

Re: Review Request 56218: Added a check test for default executor.

2017-03-16 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56218/#review169195 --- Bad patch! Reviews applied: [56218, 56213, 57696, 56217, 56215,

Re: Review Request 56218: Added a check test for default executor.

2017-03-16 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56218/ --- (Updated March 16, 2017, 4:46 p.m.) Review request for mesos, Gastón Kleiman