Re: Review Request 58305: Add some parameter validation to ReRegisterSlaveMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58305/ --- (Updated April 24, 2017, 4:59 p.m.) Review request for mesos, Mesos Reviewbot

Re: Review Request 58305: Add some parameter validation to ReRegisterSlaveMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58305/#review172799 --- src/master/master.cpp Lines 5574 (patched)

Re: Review Request 58305: Add some parameter validation to ReRegisterSlaveMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58305/ --- (Updated April 21, 2017, 4:56 p.m.) Review request for mesos, Mesos Reviewbot

Re: Review Request 58305: Add some parameter validation to ReRegisterSlaveMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58305/ --- (Updated April 20, 2017, 12:08 a.m.) Review request for mesos, Mesos Reviewbot

Re: Review Request 58305: Add some parameter validation to ReRegisterSlaveMessage.

> On April 19, 2017, 11:06 p.m., Neil Conway wrote: > > src/master/validation.cpp > > Line 835 (original), 928 (patched) > > > > > > I wonder if we should move this `internal::validateResources` call down > > to

Re: Review Request 58305: Add some parameter validation to ReRegisterSlaveMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58305/#review172420 --- src/master/validation.cpp Line 835 (original), 928 (patched)

Re: Review Request 58305: Add some parameter validation to ReRegisterSlaveMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58305/ --- (Updated April 19, 2017, 10:49 p.m.) Review request for mesos, Mesos Reviewbot

Re: Review Request 58305: Add some parameter validation to ReRegisterSlaveMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58305/#review172419 --- src/master/validation.cpp Lines 257 (patched)

Re: Review Request 58305: Add some parameter validation to ReRegisterSlaveMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58305/#review172416 --- src/master/validation.cpp Lines 241 (patched)

Re: Review Request 58305: Add some parameter validation to ReRegisterSlaveMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58305/ --- (Updated April 19, 2017, 10:05 p.m.) Review request for mesos, Mesos Reviewbot

Re: Review Request 58305: Add some parameter validation to ReRegisterSlaveMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58305/ --- (Updated April 19, 2017, 8:14 p.m.) Review request for mesos, Mesos Reviewbot

Re: Review Request 58305: Add some parameter validation to ReRegisterSlaveMessage.

> On April 17, 2017, 7:59 p.m., Neil Conway wrote: > > src/master/validation.cpp > > Lines 259 (patched) > > > > > > Personally, I'd find it more readable to say: > > > > ``` > > if

Re: Review Request 58305: Add some parameter validation to ReRegisterSlaveMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58305/#review172371 --- src/master/validation.cpp Lines 259 (patched)

Re: Review Request 58305: Add some parameter validation to ReRegisterSlaveMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58305/#review172312 --- Patch looks great! Reviews applied: [58303, 58304, 58305]

Re: Review Request 58305: Add some parameter validation to ReRegisterSlaveMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58305/ --- (Updated April 18, 2017, 10:22 p.m.) Review request for mesos, Mesos Reviewbot

Re: Review Request 58305: Add some parameter validation to ReRegisterSlaveMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58305/#review172113 --- src/master/master.cpp Lines 5570 (patched)

Re: Review Request 58305: Add some parameter validation to ReRegisterSlaveMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58305/#review172111 --- Patch looks great! Reviews applied: [58303, 58304, 58305]

Re: Review Request 58305: Add some parameter validation to ReRegisterSlaveMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58305/ --- (Updated April 17, 2017, 4:14 p.m.) Review request for mesos, Mesos Reviewbot

Re: Review Request 58305: Add some parameter validation to ReRegisterSlaveMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58305/#review171664 --- Bad patch! Reviews applied: [58305, 58304, 58303] Failed

Re: Review Request 58305: Add some parameter validation to ReRegisterSlaveMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58305/ --- (Updated April 11, 2017, 10:33 p.m.) Review request for mesos, Mesos Reviewbot

Re: Review Request 58305: Add some parameter validation to ReRegisterSlaveMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58305/ --- (Updated April 11, 2017, 4:28 p.m.) Review request for mesos and Mesos

Re: Review Request 58305: Add some parameter validation to ReRegisterSlaveMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58305/#review171449 --- Patch looks great! Reviews applied: [58303, 58304, 58305]

Review Request 58305: Add some parameter validation to ReRegisterSlaveMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58305/ --- Review request for mesos and Mesos Reviewbot. Bugs: MESOS-7372.