Re: Review Request 60562: Updated `accept` to perform operation adjustment in one place.

2017-06-30 Thread Benjamin Mahler
> On July 1, 2017, 2:13 a.m., Vinod Kone wrote: > > src/master/master.cpp > > Lines 3997 (patched) > > > > > > Can you log a warning here? I wouldn't log a warning here since it's the responsibility of the

Re: Review Request 60562: Updated `accept` to perform operation adjustment in one place.

2017-06-30 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60562/#review179454 --- Fix it, then Ship it! Made some suggestions for cleanups, feel

Re: Review Request 60562: Updated `accept` to perform operation adjustment in one place.

2017-06-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60562/#review179450 --- Fix it, then Ship it! This is great. Thanks for the cleanup.

Re: Review Request 60562: Updated `accept` to perform operation adjustment in one place.

2017-06-30 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60562/#review179395 --- src/master/master.cpp Lines 3929 (patched)

Review Request 60562: Updated `accept` to perform operation adjustment in one place.

2017-06-30 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60562/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-7735