Re: Review Request 60591: Optionally isolate only the agent network ports.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60591/#review184516 --- Ship it! Ship It! - Qian Zhang On Aug. 31, 2017, 7:20 a.m.,

Re: Review Request 60591: Optionally isolate only the agent network ports.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60591/ --- (Updated Aug. 30, 2017, 11:20 p.m.) Review request for mesos, Qian Zhang and Ji

Re: Review Request 60591: Optionally isolate only the agent network ports.

> On Aug. 21, 2017, 7:15 a.m., Qian Zhang wrote: > > src/slave/flags.cpp > > Lines 1012-1018 (patched) > > > > > > So by default this flag is not enabled, that means any libprocess-based > > exectuors (e.g., comma

Re: Review Request 60591: Optionally isolate only the agent network ports.

> On Aug. 22, 2017, 5:09 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Lines 242-246 (patched) > > > > > > Sorry for the back and forth, is it possile for `ports.isSome()`

Re: Review Request 60591: Optionally isolate only the agent network ports.

> On Aug. 21, 2017, 3:15 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Lines 183 (patched) > > > > > > This method is only called by `NetworkPortsIsolatorProcess::create()

Re: Review Request 60591: Optionally isolate only the agent network ports.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60591/ --- (Updated Aug. 24, 2017, 12:32 a.m.) Review request for mesos, Qian Zhang and Ji

Re: Review Request 60591: Optionally isolate only the agent network ports.

> On Aug. 21, 2017, 7:15 a.m., Qian Zhang wrote: > > src/slave/flags.cpp > > Lines 1012-1018 (patched) > > > > > > So by default this flag is not enabled, that means any libprocess-based > > exectuors (e.g., comma

Re: Review Request 60591: Optionally isolate only the agent network ports.

> On Aug. 22, 2017, 9:09 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Lines 183 (patched) > > > > > > Usually we put the declaration of static function at the beginning o

Re: Review Request 60591: Optionally isolate only the agent network ports.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60591/ --- (Updated Aug. 23, 2017, 9:57 p.m.) Review request for mesos, Qian Zhang and Jia

Re: Review Request 60591: Optionally isolate only the agent network ports.

> On Aug. 22, 2017, 9:09 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Lines 242-246 (patched) > > > > > > Sorry for the back and forth, is it possile for `ports.isSome()`

Re: Review Request 60591: Optionally isolate only the agent network ports.

> On Aug. 21, 2017, 7:15 a.m., Qian Zhang wrote: > > src/slave/flags.cpp > > Lines 1012-1018 (patched) > > > > > > So by default this flag is not enabled, that means any libprocess-based > > exectuors (e.g., comma

Re: Review Request 60591: Optionally isolate only the agent network ports.

> On Aug. 23, 2017, 2:10 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Lines 243-251 (patched) > > > > > > Not yours, but it seems that we do not have this check for agent

Re: Review Request 60591: Optionally isolate only the agent network ports.

> On Aug. 22, 2017, 5:09 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Lines 242-246 (patched) > > > > > > Sorry for the back and forth, is it possile for `ports.isSome()`

Re: Review Request 60591: Optionally isolate only the agent network ports.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60591/#review183566 --- src/slave/containerizer/mesos/isolators/network/ports.cpp Lines 2

Re: Review Request 60591: Optionally isolate only the agent network ports.

> On Aug. 21, 2017, 3:15 p.m., Qian Zhang wrote: > > src/slave/flags.cpp > > Lines 1012-1018 (patched) > > > > > > So by default this flag is not enabled, that means any libprocess-based > > exectuors (e.g., comma

Re: Review Request 60591: Optionally isolate only the agent network ports.

> On Aug. 21, 2017, 7:15 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Lines 245-246 (patched) > > > > > > Won't agent listen on another available ephemeral port when it i

Re: Review Request 60591: Optionally isolate only the agent network ports.

> On Aug. 22, 2017, 9:09 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Lines 242-246 (patched) > > > > > > Sorry for the back and forth, is it possile for `ports.isSome()`

Re: Review Request 60591: Optionally isolate only the agent network ports.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60591/#review183420 --- src/slave/containerizer/mesos/isolators/network/ports.cpp Lines 1

Re: Review Request 60591: Optionally isolate only the agent network ports.

> On Aug. 21, 2017, 3:15 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Lines 183 (patched) > > > > > > This method is only called by `NetworkPortsIsolatorProcess::create()

Re: Review Request 60591: Optionally isolate only the agent network ports.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60591/ --- (Updated Aug. 21, 2017, 8:36 p.m.) Review request for mesos, Qian Zhang and Jia

Re: Review Request 60591: Optionally isolate only the agent network ports.

> On Aug. 21, 2017, 7:15 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Lines 183 (patched) > > > > > > This method is only called by `NetworkPortsIsolatorProcess::create()

Re: Review Request 60591: Optionally isolate only the agent network ports.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60591/#review183303 --- src/slave/containerizer/mesos/isolators/network/ports.cpp Lines 1

Review Request 60591: Optionally isolate only the agent network ports.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60591/ --- Review request for mesos. Bugs: MESOS-7675 https://issues.apache.org/jira/b