Re: Review Request 60622: Added new stout functions for path and URI conversions.

2017-12-08 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60622/#review193292 --- Ship it! Ship It! - Andrew Schwartzmeyer On Dec. 7, 2017,

Re: Review Request 60622: Added new stout functions for path and URI conversions.

2017-12-07 Thread Jeff Coffler
> On Nov. 16, 2017, 6:08 p.m., Michael Park wrote: > > 3rdparty/stout/include/stout/uri.hpp > > Lines 19 (patched) > > > > > > This looks like an accidental include? Yup, good catch, thanks. > On Nov. 16, 2017,

Re: Review Request 60622: Added new stout functions for path and URI conversions.

2017-12-07 Thread Jeff Coffler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60622/ --- (Updated Dec. 8, 2017, 2:43 a.m.) Review request for mesos, Andrew

Re: Review Request 60622: Added new stout functions for path and URI conversions.

2017-11-16 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60622/#review191203 --- Fix it, then Ship it! 3rdparty/stout/include/stout/uri.hpp

Re: Review Request 60622: Added new stout functions for path and URI conversions.

2017-10-19 Thread Jeff Coffler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60622/ --- (Updated Oct. 19, 2017, 9:33 p.m.) Review request for mesos, Andrew

Re: Review Request 60622: Added new stout functions for path and URI conversions.

2017-10-19 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60622/#review188727 --- Ship it! Ship It! - Andrew Schwartzmeyer On Oct. 19, 2017,

Re: Review Request 60622: Added new stout functions for path and URI conversions.

2017-10-19 Thread Jeff Coffler
> On Oct. 17, 2017, 11:21 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/stout/include/stout/path.hpp > > Lines 45-52 (patched) > > > > > > The `startsWith` is unecessary. This can be replaced with one line: > >

Re: Review Request 60622: Added new stout functions for path and URI conversions.

2017-10-19 Thread Jeff Coffler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60622/ --- (Updated Oct. 19, 2017, 6:16 p.m.) Review request for mesos, Andrew

Re: Review Request 60622: Added new stout functions for path and URI conversions.

2017-10-17 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60622/#review188414 --- 3rdparty/stout/include/stout/path.hpp Lines 45-52 (patched)

Re: Review Request 60622: Added new stout functions for path and URI conversions.

2017-10-16 Thread Jeff Coffler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60622/ --- (Updated Oct. 17, 2017, 1:17 a.m.) Review request for mesos, Andrew